Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added table of standard error codes to end of custom error codes topic. #350

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

dg-concordium
Copy link
Contributor

Purpose

To inform user about hardcoded standard error codes.

Changes

Added table to end of custom errors topic.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dg-concordium dg-concordium linked an issue Dec 13, 2021 that may be closed by this pull request
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either we need to include links to the errors like they are here https://docs.rs/concordium-std/1.0.0/concordium_std/ Here are the links https://github.com/Concordium/concordium-rust-smart-contracts/blob/main/concordium-std/src/lib.rs#L130 (see section below as well) https://github.com/Concordium/concordium-rust-smart-contracts/blob/main/concordium-std/src/lib.rs#L145

Can you insert these links or do you want me to do it?

I think I should just update the documentation

@Bargsteen
Copy link
Contributor

What is the status of this PR?

@dg-concordium
Copy link
Contributor Author

What is the status of this PR?

Unfinished. It was awaiting Smart Contracts v1.

@abizjak
Copy link
Contributor

abizjak commented Oct 14, 2022

I think someone (I guess me?) should get this to completion finally.

I completely forgot about it. Thanks for the reminder @dg-concordium

@abizjak abizjak self-assigned this Oct 14, 2022
@dg-concordium dg-concordium added documentation Improvements or additions to documentation Core Blockchain For core blockchain team labels Sep 14, 2023
@Bargsteen Bargsteen requested review from abizjak, limemloh and DOBEN and removed request for LotteKh and abizjak April 25, 2024 12:11
@Bargsteen Bargsteen requested review from abizjak and removed request for abizjak April 25, 2024 12:12
@Bargsteen Bargsteen added the preview Trigger a documentation preview for a PR. label Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-26 14:31 UTC

@Bargsteen Bargsteen self-assigned this Apr 26, 2024
@Concordium Concordium deleted a comment from abizjak Apr 26, 2024
@Bargsteen Bargsteen removed the request for review from abizjak April 26, 2024 14:29
@Bargsteen Bargsteen dismissed abizjak’s stale review April 26, 2024 14:30

Changes are addressed

@Bargsteen Bargsteen merged commit 87affb6 into main Apr 26, 2024
2 checks passed
@Bargsteen Bargsteen deleted the add-smart-contract-std-error-codes branch April 26, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Blockchain For core blockchain team documentation Improvements or additions to documentation preview Trigger a documentation preview for a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand documentation of error codes for smart contracts
5 participants