Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Company ID tool #934

Merged
merged 19 commits into from
Nov 24, 2023
Merged

Company ID tool #934

merged 19 commits into from
Nov 24, 2023

Conversation

dg-concordium
Copy link
Contributor

Purpose

Documentation for the company ID tool

Changes

Change the company ID topic
Downloads

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dg-concordium dg-concordium added the preview Trigger a documentation preview for a PR. label Nov 23, 2023
@Concordium Concordium deleted a comment from github-actions bot Nov 23, 2023
@dg-concordium dg-concordium added preview Trigger a documentation preview for a PR. and removed preview Trigger a documentation preview for a PR. labels Nov 23, 2023
@Concordium Concordium deleted a comment from github-actions bot Nov 23, 2023
@dg-concordium dg-concordium added preview Trigger a documentation preview for a PR. and removed preview Trigger a documentation preview for a PR. labels Nov 23, 2023
mh-concordium
mh-concordium previously requested changes Nov 23, 2023
View reviewed changes
source/mainnet/net/guides/company-identities.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Outdated Show resolved Hide resolved
source/mainnet/net/images/company-id-recover.png Outdated Show resolved Hide resolved
source/mainnet/net/installation/downloads.rst Outdated Show resolved Hide resolved
source/mainnet/net/installation/downloads.rst Outdated Show resolved Hide resolved
source/mainnet/net/installation/downloads.rst Outdated Show resolved Hide resolved
dg-concordium and others added 11 commits November 24, 2023 06:41
@dg-concordium @mh-concordium
Update source/mainnet/net/guides/company-identities.rst
36d394c 
Co-authored-by: Martin Heinrich <[email protected]>
@dg-concordium @mh-concordium
Update source/mainnet/net/guides/company-identities.rst
443eff8 
Co-authored-by: Martin Heinrich <[email protected]>
@dg-concordium @mh-concordium
Update source/mainnet/net/guides/company-identities.rst
7cb21c8 
Co-authored-by: Martin Heinrich <[email protected]>
@dg-concordium @mh-concordium
Update source/mainnet/net/installation/downloads.rst
6926a11 
Co-authored-by: Martin Heinrich <[email protected]>
@dg-concordium @mh-concordium
Update source/mainnet/net/installation/downloads.rst
6533269 
Co-authored-by: Martin Heinrich <[email protected]>
@dg-concordium @mh-concordium
Update source/mainnet/net/installation/downloads.rst
04a79be 
Co-authored-by: Martin Heinrich <[email protected]>
@dg-concordium @mh-concordium
Update source/mainnet/net/guides/company-identities.rst
a3b949e 
Co-authored-by: Martin Heinrich <[email protected]>
@dg-concordium @mh-concordium
Update source/mainnet/net/guides/company-identities.rst
98e058c 
Co-authored-by: Martin Heinrich <[email protected]>
@dg-concordium
Address review comments
70fdf6e
@dg-concordium
Merge branch 'company-id-tool' of https://github.com/Concordium/conco…
4beffc7 
…rdium.github.io into company-id-tool
@dg-concordium
Finish addressing review comments
f30e91b
@Concordium Concordium deleted a comment from github-actions bot Nov 24, 2023
@dg-concordium dg-concordium removed the preview Trigger a documentation preview for a PR. label Nov 24, 2023
@dg-concordium dg-concordium added the preview Trigger a documentation preview for a PR. label Nov 24, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-24 11:05 UTC

abizjak
abizjak approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few leftovers from the old flow that need to be cleaned up.

source/mainnet/net/guides/company-identities.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Show resolved Hide resolved
source/mainnet/net/guides/company-identities.rst Show resolved Hide resolved
@dg-concordium dg-concordium merged commit 320cd4b into main Nov 24, 2023
2 checks passed
@dg-concordium dg-concordium deleted the company-id-tool branch November 24, 2023 11:04
mh-concordium
mh-concordium approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@mh-concordium mh-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@mh-concordium mh-concordium mh-concordium approved these changes

@bogacyigitbasi bogacyigitbasi Awaiting requested review from bogacyigitbasi

Assignees
No one assigned
Labels
preview Trigger a documentation preview for a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg-concordium @abizjak @mh-concordium