-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC documentation improvements #963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice work. I have some minor suggestions and discussions, but nothing blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
Co-authored-by: Emil Holm Gjørup <[email protected]>
Co-authored-by: Emil Holm Gjørup <[email protected]>
Co-authored-by: Emil Holm Gjørup <[email protected]>
Co-authored-by: Emil Holm Gjørup <[email protected]>
Co-authored-by: Emil Holm Gjørup <[email protected]>
Co-authored-by: Kasper Dissing Bargsteen <[email protected]>
Co-authored-by: Kasper Dissing Bargsteen <[email protected]>
I think I got all of the videos embedded, but please check to make sure that I got the correct ones in the correct places as the copy/paste got a bit confusing. |
All of the changes should be done. Please review @Bargsteen and @limemloh. |
I noticed that the dimensions of the videos are fixed and they seem small at least on my screen. I think we should remove the fixed dimensions (560x315) for all of our videos and add a CSS rule: iframe {
width: 100%;
aspect_ratio: 16 / 9;
} (We can also add a As that gives us this: It also scales better on small devices. |
Once again, the changes are made. Please review @Bargsteen |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
Purpose
Improve smart contract documentation based on comments from Kasper and some outstanding pull requests. Note that this does NOT include changes to the tutorials.
Changes
A number of sc files
Conf.py (redirects)
Requirements.txt because something broke
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.