Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting documentation #986

Merged
merged 32 commits into from
Mar 22, 2024
Merged

Voting documentation #986

merged 32 commits into from
Mar 22, 2024

Conversation

dg-concordium
Copy link
Contributor

@dg-concordium dg-concordium commented Mar 5, 2024

Purpose

Add documentation to describe voting tools.

Changes

Voting section in index and topics.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dg-concordium dg-concordium linked an issue Mar 7, 2024 that may be closed by this pull request
@dg-concordium dg-concordium marked this pull request as ready for review March 18, 2024 09:31
@dg-concordium dg-concordium added the preview Trigger a documentation preview for a PR. label Mar 18, 2024
@dg-concordium dg-concordium added preview Trigger a documentation preview for a PR. and removed preview Trigger a documentation preview for a PR. labels Mar 18, 2024
Copy link

github-actions bot commented Mar 18, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-22 13:20 UTC

Copy link
Contributor

@chportma chportma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few minor comments that you can reject if you feel that they aren't helpful.

source/mainnet/net/voting/gc-voting.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/gc-voting.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/gc-voting.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/gc-voting.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/guardians.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things

source/mainnet/net/voting/voting.rst Show resolved Hide resolved
source/mainnet/net/images/voting/dw-vote-delegation.png Outdated Show resolved Hide resolved
source/mainnet/net/images/voting/mwgen1-delegate-vote.png Outdated Show resolved Hide resolved
source/mainnet/net/voting/coordinator.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/guardians.rst Show resolved Hide resolved
source/mainnet/net/voting/guardians.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/guardians.rst Show resolved Hide resolved
source/mainnet/net/voting/guardians.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/voting.rst Show resolved Hide resolved
source/mainnet/net/voting/voting.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/voting.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/voting.rst Outdated Show resolved Hide resolved
source/mainnet/net/voting/coordinator.rst Outdated Show resolved Hide resolved
@dg-concordium dg-concordium merged commit 1fef9d0 into main Mar 22, 2024
2 checks passed
@dg-concordium dg-concordium deleted the voting-doc branch March 22, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Trigger a documentation preview for a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voting documentation
4 participants