Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation about mode, remove unused param #6

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Update documentation about mode, remove unused param #6

merged 4 commits into from
Mar 22, 2022

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Mar 10, 2022 •
edited
Loading

Description

  1. Updates documentation about operation mode (cdc, snapshot)
  2. Removes unused replication_url parameter.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests. -- not needed
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner March 10, 2022 15:08
@hariso
Copy link
Contributor Author

hariso commented Mar 10, 2022

I just noticed #2. If there's much more planned work on updating the ReadMe than it's in this PR, we can close this one.

@lovromazgon
Copy link
Member

There is probably more work needed here, let's postpone this a bit and get back to it in a week or two.

dylanlott
dylanlott approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the default values for the slot and publication name, too. LGTM.

@hariso
Copy link
Contributor Author

hariso commented Mar 22, 2022

I updated the default values for the slot and publication name, too. LGTM.

💪

@hariso hariso merged commit dcb262f into main Mar 22, 2022
@hariso hariso deleted the haris/docs branch March 22, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanlott dylanlott dylanlott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hariso @lovromazgon @dylanlott