Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation script #169

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Add installation script #169

merged 10 commits into from
Oct 18, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Oct 17, 2024

@hariso hariso requested a review from a team as a code owner October 17, 2024 16:10
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024

Deploying conduit-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 69ac2e1
Status: ✅  Deploy successful!
Preview URL: https://ab6f0b21.conduit-site.pages.dev
Branch Preview URL: https://haris-add-installation-scrip.conduit-site.pages.dev

View logs

@hariso
Copy link
Contributor Author

hariso commented Oct 17, 2024

Actually, now that it's in this repo, I can update the installation instructions as well. Still, feel free to review the script itself.

@hariso hariso enabled auto-merge (squash) October 17, 2024 16:37
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try to make the installation output a bit more "attractive", currently it looks a bit rough around the edges.

@hariso
Copy link
Contributor Author

hariso commented Oct 17, 2024

Output of successful installation:

Screenshot from 2024-10-17 20-23-11

Output of failed installation:

Screenshot from 2024-10-17 20-22-42

hariso and others added 2 commits October 17, 2024 22:20
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more suggestions, but looks good otherwise 👍 👏

@hariso hariso merged commit d64fd02 into main Oct 18, 2024
1 check passed
@hariso hariso deleted the haris/add-installation-script branch October 18, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation script for Linux OSes
3 participants