Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Grumpkin elliptic curve (2-cycle with BN254) #625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yelhousni
Copy link
Collaborator

@yelhousni yelhousni commented Feb 3, 2025

Description

This PR implements Grumpkin elliptic curve. It forms a 2-cycle with BN254. It might come in handy for sumcheck based explorations that are compatible with Ethereum.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Available tests for other curves are generated for Grumpkin and pass.

How has this been benchmarked?

Performances should be similar to BN254.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant