-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add account drawer UI for account switch #516
Conversation
…/starknet-snap into feat/account-drawer-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work—this looks great! Just one minor comment: when the last hidden account is unhidden
the interface should automatically switch to display the visible
accounts. WDYT?
The change is easy, but i found that, i may getting a bit lost after all hidden account visible, because it suddenly appear some accounts after i remove the last hidden account so i think for now , we keep it like that, and may require a designer to refine that UX , wdyt? |
I see could we then maybe have a text just saying no hidden account instead oƒ empty screen wdyt ? |
i think that is better |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is to add Account Drawer UI to replace AccountSwitch pull menu, which enable the end user switch an account from a larger interface
Change
AccountDrawer
modal components to show the visible and hidden list of accountsAccountDrawer
modal componentsScrollable
for scroll bar viewRequirement