Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add account drawer UI for account switch #516

Merged
merged 23 commits into from
Feb 25, 2025
Merged

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Feb 18, 2025

This PR is to add Account Drawer UI to replace AccountSwitch pull menu, which enable the end user switch an account from a larger interface

Change

  • Add AccountDrawer modal components to show the visible and hidden list of accounts
  • Enable end user to switch, hide, show accounts on the AccountDrawer modal components
  • Add reusable component Scrollable for scroll bar view
  • Remove SwitchAccount components

Requirement

@stanleyyconsensys stanleyyconsensys marked this pull request as ready for review February 18, 2025 07:06
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner February 18, 2025 07:06
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and jonesho and removed request for a team February 18, 2025 07:06
@stanleyyconsensys stanleyyconsensys changed the title feat: Add Account drawer UI for account switch feat: add account drawer UI for account switch Feb 18, 2025
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work—this looks great! Just one minor comment: when the last hidden account is unhidden the interface should automatically switch to display the visible accounts. WDYT?

@stanleyyconsensys
Copy link
Collaborator Author

stanleyyconsensys commented Feb 25, 2025

unhidden

The change is easy, but i found that, i may getting a bit lost after all hidden account visible, because it suddenly appear some accounts after i remove the last hidden account

so i think for now , we keep it like that, and may require a designer to refine that UX , wdyt?

@khanti42
Copy link
Collaborator

khanti42 commented Feb 25, 2025

unhidden

The change is easy, but i found that, i may getting a bit lost after all hidden account visible, because it suddenly appear some accounts after i remove the last hidden account

so i think for now , we keep it like that, and may require a designer to refine that UX , wdyt?

I see could we then maybe have a text just saying no hidden account instead oƒ empty screen wdyt ?

@stanleyyconsensys
Copy link
Collaborator Author

saying

i think that is better

Base automatically changed from chore/fix-ui-redux-state-over-listen to main February 25, 2025 11:00
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khanti42 khanti42 added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit ed2b4d6 Feb 25, 2025
15 checks passed
@khanti42 khanti42 deleted the feat/account-drawer-ui branch February 25, 2025 12:56
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants