Create Envs, a factory for making mock Envs
#2442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
reviewed
Apr 7, 2025
packages/std/src/testing/mock.rs
Outdated
|
|
||
| pub fn make(&mut self) -> Env { | ||
| let height = self.last_height + 1; | ||
| let time = self.last_time.plus_seconds(5); |
There was a problem hiding this comment.
Would it make sense to make the time increment configurable?
There was a problem hiding this comment.
A lot of things are configurable now. See EnvsOptions
| /// assert_eq!(env.block.time, Timestamp::from_nanos(1_571_797_419_879_305_533).plus_seconds((index*5) as u64)); | ||
| /// } | ||
| /// ``` | ||
| pub struct Envs { |
There was a problem hiding this comment.
Maybe a more specific name would be better? Envs sounds very generic and doesn't really indicate that this is for testing only.
There was a problem hiding this comment.
Happy for suggestions. But I doubt this will be used in the majority of test code.
You have to import it through cosmwasm_std::testing::Envs, so testing is implied here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential solution for #2218. Not necessarily ready yet but I wonder if this looks good.
Closes #2218