Make export_schema_with_title argument immutable

CHANGELOG.md

@@ -196,6 +196,8 @@ and this project adheres to
   `StakingQuery::Validator`, `ValidatorResponse` and
   `QuerierWrapper::query_validator` to allow querying a single validator.
   ([#879])
+- cosmwasm-schema: Make first argument non-mutable in `export_schema_with_title`
+  for consistency with `export_schema`.
 
 [#696]: https://github.com/CosmWasm/cosmwasm/issues/696
 [#697]: https://github.com/CosmWasm/cosmwasm/issues/697

contracts/ibc-reflect/examples/schema.rs

@@ -18,17 +18,17 @@ fn main() {
     export_schema(&schema_for!(QueryMsg), &out_dir);
     export_schema(&schema_for!(PacketMsg), &out_dir);
     export_schema_with_title(
-        &mut schema_for!(AcknowledgementMsg<BalancesResponse>),
+        &schema_for!(AcknowledgementMsg<BalancesResponse>),
         &out_dir,
         "AcknowledgementMsgBalances",
     );
     export_schema_with_title(
-        &mut schema_for!(AcknowledgementMsg<DispatchResponse>),
+        &schema_for!(AcknowledgementMsg<DispatchResponse>),
         &out_dir,
         "AcknowledgementMsgDispatch",
     );
     export_schema_with_title(
-        &mut schema_for!(AcknowledgementMsg<WhoAmIResponse>),
+        &schema_for!(AcknowledgementMsg<WhoAmIResponse>),
         &out_dir,
         "AcknowledgementMsgWhoAmI",
     );

packages/schema/src/export.rs

@@ -20,13 +20,13 @@ pub fn export_schema(schema: &RootSchema, out_dir: &Path) {
 
 // use this if you want to override the auto-detected name of the object.
 // very useful when creating an alias for a type-alias.
-pub fn export_schema_with_title(schema: &mut RootSchema, out_dir: &Path, title: &str) {
-    // set the title explicitly on the schemas metadata
-    let metadata = &mut schema.schema.metadata;
-    if let Some(data) = metadata {
-        data.title = Some(title.to_string());
+pub fn export_schema_with_title(schema: &RootSchema, out_dir: &Path, title: &str) {
+    let mut schema = schema.clone();
+    // set the title explicitly on the schema's metadata
+    if let Some(metadata) = &mut schema.schema.metadata {
+        metadata.title = Some(title.to_string());
     }
-    write_schema(schema, out_dir, &title);
+    write_schema(&schema, out_dir, &title);
 }
 
 /// Writes schema to file. Overwrites existing file.

packages/std/examples/schema.rs

@@ -11,5 +11,5 @@ fn main() {
     remove_schemas(&out_dir).unwrap();
 
     export_schema(&schema_for!(Timestamp), &out_dir);
-    export_schema_with_title(&mut schema_for!(CosmosMsg), &out_dir, "CosmosMsg");
+    export_schema_with_title(&schema_for!(CosmosMsg), &out_dir, "CosmosMsg");
 }