Skip to content

fix: collect_str is reachable #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: collect_str is reachable #70

wants to merge 1 commit into from

Conversation

benluelo
Copy link

@benluelo benluelo commented Mar 17, 2025 •
edited
Loading

fixes #69

@chipshort
Copy link

This is probably a leftover of this being a fork of serde-json-core which is for no_std environments.
Could you add a test that fails without the change and is fixed with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collect_str unimplemented
2 participants
@benluelo @chipshort