Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Use txid_limit only in get_oldest_tx() #23

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Use txid_limit only in get_oldest_tx() #23

merged 1 commit into from
Mar 25, 2024

Conversation

ouziel-slama
Copy link
Contributor

No description provided.

@ouziel-slama
Copy link
Contributor Author

(not tested)

@ouziel-slama
Copy link
Contributor Author

works! thanks @mattmarcello !

@adamkrellenstein
Copy link
Member

hm, I don't understand this...

@ouziel-slama
Copy link
Contributor Author

The txid_limit variable is used in several functions including get_utxos() and get_oldest_tx(). There is only get_oldest_tx() for which we are obliged to leave the txid_limit equal to 100 so as not to break the consensus. For the other functions, which are used to compose transactions, we do not need to keep this parameter which prevents, for example, composing a transaction with an address that has more than 100 transactions.

@mattmarcello mattmarcello mentioned this pull request Mar 25, 2024
Closed
@adamkrellenstein adamkrellenstein merged commit d7bcd05 into master Mar 25, 2024
1 check passed
@adamkrellenstein adamkrellenstein deleted the txidlimit branch March 25, 2024 19:20
@ouziel-slama ouziel-slama mentioned this pull request Apr 1, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel