-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to rails 7.2, ruby {3.2, 3.3} and add test config #6
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ on: | |
branches: ['master'] | ||
schedule: | ||
- cron: '0 0 * * 0' | ||
workflow_dispatch: | ||
|
||
permissions: | ||
contents: read | ||
|
@@ -23,12 +24,15 @@ jobs: | |
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
ruby-version: ['3.0', '3.1', '3.2'] | ||
activerecord: ['6.0', '6.1', '7.0', '7.1'] | ||
ruby-version: ['3.0', '3.1', '3.2', '3.3'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actually, since now we're already in Rails 7.0 and Ruby 3.1, we only need the testing for
The inclusion of Rails 6.0, 6.1 and also Ruby 3.0 is okay, just that it's redundant for our codebase (this library is only for our internal usage anyway) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed the rails 6 configurations, leaving behind rails 7.0, 7.1, 7.2 and Ruby 3.0, 3.1, 3.2, 3.3. |
||
activerecord: ['7.0', '7.1', '7.2'] | ||
exclude: | ||
- ruby-version: '3.0' | ||
activerecord: '7.2' | ||
env: | ||
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.activerecord }}.gemfile | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@v4 | ||
- name: Set up Ruby | ||
# To automatically get bug fixes and new Ruby versions for ruby/setup-ruby, | ||
# change this to (see https://github.com/ruby/setup-ruby#versioning): | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,11 @@ | ||
appraise "rails-6.0" do | ||
gem 'rails', '6.0.6.1' | ||
end | ||
|
||
appraise "rails-6.1" do | ||
gem 'rails', '~> 6.1' | ||
end | ||
|
||
appraise "rails-7.0" do | ||
gem 'rails', '~> 7.0' | ||
end | ||
|
||
appraise "rails-7.1" do | ||
gem 'rails', '~> 7.1' | ||
end | ||
|
||
appraise "rails-7.2" do | ||
gem 'rails', '~> 7.2' | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ require 'active_record/acts_as/version' | |
Gem::Specification.new do |spec| | ||
spec.name = "active_record-acts_as" | ||
spec.version = ActiveRecord::ActsAs::VERSION | ||
spec.authors = ["Hassan Zamani", "Manuel Meurer"] | ||
spec.authors = ["Hassan Zamani", "Manuel Meurer", "Bivan Alzacky Harmanto", "Adi Suryanata Herwana"] | ||
spec.email = ["[email protected]", "[email protected]"] | ||
spec.summary = %q{Simulate multi-table inheritance for activerecord models} | ||
spec.description = %q{Simulate multi-table inheritance for activerecord models using a plymorphic association} | ||
|
@@ -28,6 +28,6 @@ Gem::Specification.new do |spec| | |
spec.add_development_dependency "appraisal", "~> 2.1" | ||
spec.add_development_dependency "guard-rspec", "~> 4.7" | ||
|
||
spec.add_dependency "activesupport", ">= 6.0" | ||
spec.add_dependency "activerecord", ">= 6.0" | ||
spec.add_dependency "activesupport", ">= 7.0" | ||
spec.add_dependency "activerecord", ">= 7.0" | ||
end |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
module ActiveRecord | ||
module ActsAs | ||
VERSION = "4.0.0" | ||
VERSION = "4.0.1" | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please consider carefully if you might need to remove this cron.. If you maintain this, the testing will be run once a week and last time, the test failed unexpectedly while nothing has changed.
You might want to investigate those as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
workflow_dispatch
trigger to run actions manually to resolve intermittent failures.