-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timed Assessment: Timer starts only when user click "Start" while initiating Attempt #7548
Open
bivanalhar
wants to merge
2
commits into
master
Choose a base branch
from
bivan/timed-assessment-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c79d3b
to
181cb3b
Compare
cysjonathan
requested changes
Sep 12, 2024
client/app/bundles/course/assessment/submission/pages/SubmissionEditIndex/index.jsx
Outdated
Show resolved
Hide resolved
181cb3b
to
0e7b329
Compare
0e7b329
to
b9fceae
Compare
b9fceae
to
37f55ee
Compare
cysjonathan
requested changes
Nov 15, 2024
...urse/assessment/submission/pages/SubmissionEditIndex/components/RemainingTimeTranslation.tsx
Outdated
Show resolved
Hide resolved
app/jobs/course/assessment/submission/force_submit_timed_submission_job.rb
Outdated
Show resolved
Hide resolved
...urse/assessment/submission/pages/SubmissionEditIndex/components/RemainingTimeTranslation.tsx
Outdated
Show resolved
Hide resolved
client/app/bundles/course/assessment/submission/pages/SubmissionsIndex/SubmissionsTableRow.jsx
Outdated
Show resolved
Hide resolved
client/app/bundles/course/assessment/submission/translations.ts
Outdated
Show resolved
Hide resolved
client/app/bundles/course/assessment/submission/translations.ts
Outdated
Show resolved
Hide resolved
client/app/bundles/course/assessment/components/AssessmentForm/translations.ts
Outdated
Show resolved
Hide resolved
b0c23f5
to
6a2e839
Compare
40607df
to
2c4ac97
Compare
- timer starts only after student click "Start" when start attempting the exam
- if submission already has timer started at, we won't allow to re-configure it - add test cases regarding this API - refactor the TimeLimitBanner to accommodate when timer not started yet
2c4ac97
to
2c7d2e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.