-
Notifications
You must be signed in to change notification settings - Fork 78
Programming Question Audit Trail #7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
syoopie
wants to merge
21
commits into
master
Choose a base branch
from
yupei/programming-question-audit-trail
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42b2875 to
1bbfd55
Compare
cysjonathan
requested changes
Oct 22, 2024
app/views/course/assessment/question/programming/_programming.json.jbuilder
Show resolved
Hide resolved
2f05498 to
2d65d34
Compare
2d65d34 to
32b673b
Compare
547ba38 to
1c65185
Compare
add parentId for: - programming auto grading - programming question
- include an option to add elipses beside the title to better indicate that accordion can be opened
- make new of new accordion ellipses feature
- QuestionDetails -> Question - AllAnswerDetails -> Answer - previous naming was verbose and communicated the wrong idea of what information the type has - free up naming for use in details components
1c65185 to
603e962
Compare
- submitted_at is more indicative of the actual data
- changed naming for files and added specific typing for latest answer - fix bug where if a question is added after submission, the page crashes
603e962 to
051ce26
Compare
- updated types for processed vs non processed data - removed unnecessary data from jbuilders - added parsing / processing of programming question data and linked to display
- lines removed is data that is no longer being rendered
- use update column instead of update to prevent validation error when duplicating question with deprecated programming language
- also add redicrect edit url to return when updating question, so that id can be used to revalidate question
- this situation can occur when question is added after submission
051ce26 to
9183fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Old Behavior - When question is updated and regrading is triggered, there was no preservation of the:
This resulted in a dilemma when randomness in test cases (such as in machine learning) resulted in a student failing test cases that were previously passing
Details
course_assessment_question_programmingandcourse_assessment_answer_programming_auto_gradings