feat(past-answers): merged existing past answers submission/statistics views #7763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-herwana-nus
commented
Jan 21, 2025
adi-herwana-nus
commented
- implemented combined view, can toggle between "timeline" (old statistics) and "sequence" (old submission) view
- moved / reworked existing view files into submission directory
- re-implemented answer history state reducers in typescript
- migrated old statistics answer types to submission AnswerData types
- tweaked /statistsics/answer/show API to maintain parity with other data type
- tweaked submissions API to new history format, return questionNumber as number
adi-herwana-nus
force-pushed
the
adi/past-answers-unification
branch
from
4832dc7 to
9e7efc2
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| describe '#show' do | ||
| render_views | ||
| subject { get :show, format: :json, params: { course_id: course, assessment_id: assessment, submission_id: submission, id: answer.id } } |
There was a problem hiding this comment.
[Correctable] Layout/LineLength: Line is too long. [144/120]
| @@ -21,7 +21,7 @@ | |||
| subject do | |||
| get :all_answers, | |||
| format: :json, | |||
| params: { course_id: course, submission_id: answer.submission_id, question_id: answer.question_id } | |||
| params: { course_id: course, id: assessment, submission_id: answer.submission_id, question_id: answer.question_id } | |||
There was a problem hiding this comment.
[Correctable] Layout/LineLength: Line is too long. [127/120]
added 2 commits
January 22, 2025 19:33
…s views - implemented combined view, can toggle between "timeline" (old statistics) and "sequence" (old submission) view - moved / reworked existing view files into submission directory - re-implemented answer history state reducers in typescript - migrated old statistics answer types to submission AnswerData types - tweaked /statistsics/answer/show API to maintain parity with other data type - tweaked submissions API to new history format, return questionNumber as number
adi-herwana-nus
force-pushed
the
adi/past-answers-unification
branch
from
93d8bd4 to
ff8ffdf
Compare
| @@ -290,9 +290,9 @@ | |||
| end | |||
| end | |||
|
|
|||
| get 'submissions/:submission_id/questions/:question_id/all_answers', on: :member, to: 'submission_question/submission_questions#all_answers', as: 'submission_question_custom' | |||
There was a problem hiding this comment.
[Correctable] Layout/LineLength: Line is too long. [184/120]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.