Skip to content

Multiline Packager signs cannot represent continuous strings #10773

Description

@ThinkWithPbody

Description

Multiline Packager signs currently insert a space between every non-empty line, making it impossible to represent any continuous address string longer than one sign line. For example:

Player-Central-
Access

is read as Player-Central- Access instead of Player-Central-Access. In the same way, long address such as verylongfactoryaddressname cannot be split across sign lines without changing the actual address.

Since the line breaks are primarily a visual limitation of signs, I think the cleaner behaviour would be for Packagers to concatenate non-empty lines directly, without automatically inserting spaces, so the above example becomes Player-Central-Access.

Players who want spaces should also be able to type them explicitly where needed. The current code from 6.0.2 literally says:

if (!string.isBlank())
  address += string.trim() + " ";

If changing the existing behaviour to address += string; is considered too disruptive for backwards compatibility, a secondary option would be an explicit continuation character, such as a trailing \, which suppresses the inserted space:

verylongfactory\
addressname

becomes verylongfactoryaddressname. This would at least allow arbitrary address strings to be represented without special-casing particular separators.

Game Log

NA

Debug Information

NA

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugIssue where something isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions