Create 6.0.8 Breaks ComputerCraft Inventory Interaction with Create_Packager

[HKXingluo]

Description

I've encountered an issue with the Create_Packager from Create version 6.0.8. You've added ComputerCraft API support to allow retrieving package-related information, but in doing so, you removed the default ComputerCraft container inventory API methods (pushItems, pullItems) as documented here: https://tweaked.cc/generic_peripheral/inventory.html.

As a result, the Create_Packager can no longer perform internal item transfer operations via ComputerCraft.

In previous versions of Create—before the package API was introduced—the peripheral did expose the standard inventory API and allowed normal item transportation. Now, that functionality is missing.

Game Log

no log

Debug Information

Client Info

Create:
	Mod Version: 6.0.8
	Mod Git Commit: 1a1a9a2819b4f89f78caec41b55ed8cb222fa24b
	Ponder Version: 1.0.91
	Forge Version: 47.3.0
	Minecraft Version: 1.20.1

Graphics:
	Flywheel Version: 1.0.5
	Flywheel Backend: flywheel:instancing
	OpenGL Renderer: NVIDIA GeForce RTX 2070/PCIe/SSE2
	OpenGL Version: 4.6.0 NVIDIA 561.09
	Graphics Mode: fancy
	PojavLauncher Detected: false

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 18.0.2.1, Oracle Corporation
	JVM Flags: 6 total; -XX:+UseG1GC -XX:-UseAdaptiveSizePolicy -XX:-OmitStackTraceInFastThrow -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmn2457m -Xmx16384m
	Memory: 1282374864 bytes (1222 MiB) / 4479516672 bytes (4272 MiB) up to 17179869184 bytes (16384 MiB)
	Total Memory: 3204474296 bytes (3056 MiB) / 4479516672 bytes (4272 MiB)
	CPU: 12th Gen Intel(R) Core(TM) i3-12100F @ 3.30 GHz; 4 cores / 8 threads on 1 socket(s)
	Graphics card #0: Virtual Desktop Monitor (Virtual Desktop, Inc.); 0.00 MB of VRAM
	Graphics card #1: GameViewer Virtual Display Adapter (GameViewer); 0.00 MB of VRAM
	Graphics card #2: NVIDIA GeForce RTX 2070 (NVIDIA (0x10de)); 4095.00 MB of VRAM

Other Mods:
	KumaAPI: 20.1.10
	KubeJS: 2001.6.5-build.16
	Advanced Peripherals: 0.7.46r
	GeckoLib 4: 4.7.1.2
	Eidolon:Repraised: 0.3.8.15
	BotaniaTubes: 1.0.0
	KubeJS Mekanism: 2001.1.5.1-build.2
	Uppers: 1.0.1
	Wooden Hopper: 1.20.1-1.6.0.1
	Sophisticated Core: 1.2.69.1005
	Rubidium (Embeddium): 0.7.1
	Thermal Series: 11.0.6
	Controlling: 12.0.2
	Placebo: 8.6.3
	Plushie Buddies: 0.1.6-1.20.1
	Create: Central Kitchen: 1.4.1
	MixinExtras: 0.2.0
	Resource Pack Overrides: 8.0.3
	Musket Mod: 1.5.4
	Sophisticated Backpacks: 3.23.19.1251
	KubeJS-EnderIO: 1.20.1-0.6.0
	Balm: 7.3.31
	Melody: 1.0.2
	Just Enough Resources: 1.4.0.247
	Exposure: 1.7.16
	CFM Refurbished: Circuit Breaker: 1.0.0
	BaguetteLib: 1.0.0
	Cloth Config v10 API: 11.1.136
	FTB Teams: 2001.3.1
	Supplementaries: 1.20-3.1.30
	Konkrete: 1.8.0
	Embeddium: 0.3.31+mc1.20.1
	Corpse: 1.20.1-1.0.20
	Farmer's Delight: 1.20.1-1.2.8
	Entity Model Features: 2.4.1
	Entity Texture Features: 6.2.9
	FTB XMod Compat: 2.1.3
	'Dustrial Decor: 1.3.2
	Tempad: 2.3.4
	Thermal Innovation: 11.0.1
	Just Enough Archaeology: 1.20.1-1.0.4
	End Remastered: 5.3.3-R-1.20.1
	Moyai: 1.20-2.1.4
	Botania: 1.20.1-448-FORGE
	Resourcefulconfig: 2.1.3
	Fairy Lights: 7.0.0
	Actually Subtractions: 1.2.14.14+mc1.20.1
	Curios API: 5.14.1+1.20.1
	Patchouli: 1.20.1-84.1-FORGE
	Collective: 8.3
	KubeJSDelight: 1.1.2
	Camera Mod: 1.20.1-1.0.20
	Searchables: 1.0.3
	Time In A Bottle: 4.0.4-mc1.20.1
	Thermal Foundation: 11.0.6
	Thermal Expansion: 11.0.1
	Joy of Painting: 1.20.1-1.0.1
	Resourceful Lib: 2.1.29
	Construction Wand: 1.20.1-2.11
	LootJS: 1.20.1-2.13.0
	Architectury: 9.2.14
	CC: Tweaked: 1.116.2
	AI-Improvements: 0.5.2
	Chimes: 2.0.1
	MrCrayfish's Furniture Mod: Refurbished: 1.0.12
	Jade Addons: 5.5.0+forge
	Inventory Essentials: 8.2.7
	Framework: 0.7.15
	Fast Leaf Decay: 32
	Yeetus Experimentus: 2.3.1-build.6+mc1.20.1
	Simple Discord Rich Presence: 4.0.3-build.40+mc1.20.1
	AntiBlocksReChiseled: 0.4.6
	Thermal Dynamics: 11.0.1
	SmartBrainLib: 1.15
	Drip Sounds: 0.3.2
	Kiwi Library: 11.8.31+forge
	Simple Inventory Sorter: 23.0.8
	Rhino: 2001.2.3-build.10
	FTB Library: 2001.2.9
	Amendments: 1.20-1.2.19
	Berry Good: 7.0.0
	Snad: 20.1.0
	CustomSkinLoader: 14.26.1
	Create: Copycats+: 3.0.2+mc.1.20.1-forge
	Just Enough Items: 15.20.0.112
	Applied Energistics 2: 15.4.4
	Create Low-Heated: 1.20.1-6.0.2-3
	Jess' Painting Collection: 1.19.2
	Underground Beacons: 1.0
	Mekanism: 10.4.16
	KubeJS Thermal: 2001.1.10-build.2
	Decorative Blocks: 4.1.3
	CoFH Core: 11.0.2
	Create: Escalated: 1.1.0
	Table Top Craft: 1.20.1-6.1.2
	GuideME: 20.1.7
	corpsecurioscompat: 3.0.2
	Fusion: 1.2.7+b
	Blueprint: 7.1.3
	AzureLib: 3.0.6
	Chalk: 1.6.6
	Just Enough Immersive Multiblocks: 1.0.4
	Neapolitan: 5.1.0
	Nyf's Spiders: 2.1.1
	CraftingTweaks: 18.2.5
	Tinkers' Construct: 3.10.0.67
	Storage Shelves: 1.0.0
	Simple Voice Chat: 1.20.1-2.5.30
	TerraBlender: 3.0.1.10
	Moonlight Library: 1.20-2.14.1
	Mouse Tweaks: 2.25.1
	Eccentric Tome: 1.20.1-1.10.3
	FTB Quests: 2001.4.13
	Immersive Engineering: 1.20.1-10.2.0-183
	MixinSquared: 0.2.0
	Jade: 11.13.1+forge
	All The Leaks: 0.1.4-beta+1.20.1-forge
	Ceramic Bucket: 1.20.1-4.1.0.0
	Fast Paintings: 1.20-1.2.7
	Ender IO: 6.2.11-beta
	Kotlin For Forge: 4.11.0
	Brewin' And Chewin': 1.20.1-3.2.1
	Mantle: 1.11.55
	Lexiconfig: 1.4.18-1
	BucketLib: 1.20.1-2.3.7.0
	Thermal Cultivation: 11.0.1
	Fast Workbench: 8.0.4
	Storage Drawers: 12.9.14
	AlmostUnified: 1.20.1-0.10.0
	Miner's Delight: 1.20.1-1.2.3
	KubeJS Botania: 1.4.0
	FancyMenu: 3.6.4
	KubeJS Create: 2001.3.0-build.8
	FastFurnace: 8.0.2
	AppleSkin: 2.5.1+mc1.20.1
	Ferrite Core: 6.0.1
	Visuality: Reforged: 2.0.2
	Lychee Tweaker: 5.1.19+forge
	PacketFixer: 3.1.4
	Block Of Sky: 0.3.0
	Simple Radio: 3.4.6
	Create Enchantment Industry: 1.3.2-for-create-6.0.4
	Create Crafts & Additions: 1.20.1-1.3.1

Server Info

Create:
	Mod Version: 6.0.8
	Mod Git Commit: 1a1a9a2819b4f89f78caec41b55ed8cb222fa24b
	Ponder Version: 1.0.91
	Forge Version: 47.3.0
	Minecraft Version: 1.20.1

System Information:
	Operating System: Linux (amd64) version 6.1.0-21-amd64
	Java Version: 17.0.8, Red Hat, Inc.
	JVM Flags: 1 total; -Xmx10G
	Memory: 4793867864 bytes (4571 MiB) / 9453961216 bytes (9016 MiB) up to 10737418240 bytes (10240 MiB)
	Total Memory: 4668481960 bytes (4452 MiB) / 9453961216 bytes (9016 MiB)
	CPU: Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz @ 2.60 GHz; 28 cores / 56 threads on 2 socket(s)
	Graphics card #0: unknown (unknown); 0.00 MB of VRAM

Other Mods:
	KumaAPI: 20.1.10
	KubeJS: 2001.6.5-build.16
	Advanced Peripherals: 0.7.46r
	GeckoLib 4: 4.7.1.2
	Eidolon:Repraised: 0.3.8.15
	BotaniaTubes: 1.0.0
	KubeJS Mekanism: 2001.1.5.1-build.2
	Uppers: 1.0.1
	Wooden Hopper: 1.20.1-1.6.0.1
	Sophisticated Core: 1.2.69.1005
	Rubidium (Embeddium): 0.7.1
	Thermal Series: 11.0.6
	Controlling: 12.0.2
	Placebo: 8.6.3
	Plushie Buddies: 0.1.6-1.20.1
	Create: Central Kitchen: 1.4.1
	MixinExtras: 0.2.0
	Resource Pack Overrides: 8.0.3
	Musket Mod: 1.5.4
	Sophisticated Backpacks: 3.23.19.1251
	KubeJS-EnderIO: 1.20.1-0.6.0
	Balm: 7.3.31
	Melody: 1.0.2
	Just Enough Resources: 1.4.0.247
	Exposure: 1.7.16
	CFM Refurbished: Circuit Breaker: 1.0.0
	BaguetteLib: 1.0.0
	Cloth Config v10 API: 11.1.136
	FTB Teams: 2001.3.1
	Supplementaries: 1.20-3.1.30
	Konkrete: 1.8.0
	Embeddium: 0.3.31+mc1.20.1
	Corpse: 1.20.1-1.0.20
	Farmer's Delight: 1.20.1-1.2.8
	Entity Model Features: 2.4.1
	Entity Texture Features: 6.2.9
	FTB XMod Compat: 2.1.3
	'Dustrial Decor: 1.3.2
	Tempad: 2.3.4
	Thermal Innovation: 11.0.1
	Just Enough Archaeology: 1.20.1-1.0.4
	End Remastered: 5.3.3-R-1.20.1
	Moyai: 1.20-2.1.4
	Botania: 1.20.1-448-FORGE
	Resourcefulconfig: 2.1.3
	Fairy Lights: 7.0.0
	Actually Subtractions: 1.2.14.14+mc1.20.1
	Curios API: 5.14.1+1.20.1
	Patchouli: 1.20.1-84.1-FORGE
	Collective: 8.3
	KubeJSDelight: 1.1.2
	Camera Mod: 1.20.1-1.0.20
	Searchables: 1.0.3
	Time In A Bottle: 4.0.4-mc1.20.1
	Thermal Foundation: 11.0.6
	Thermal Expansion: 11.0.1
	Joy of Painting: 1.20.1-1.0.1
	Resourceful Lib: 2.1.29
	WorldEdit: 7.2.15+6463-5ca4dff
	Construction Wand: 1.20.1-2.11
	LootJS: 1.20.1-2.13.0
	Architectury: 9.2.14
	CC: Tweaked: 1.116.2
	AI-Improvements: 0.5.2
	Chimes: 2.0.1
	MrCrayfish's Furniture Mod: Refurbished: 1.0.12
	Jade Addons: 5.5.0+forge
	Inventory Essentials: 8.2.7
	Framework: 0.7.15
	Fast Leaf Decay: 32
	Yeetus Experimentus: 2.3.1-build.6+mc1.20.1
	Simple Discord Rich Presence: 4.0.3-build.40+mc1.20.1
	AntiBlocksReChiseled: 0.4.6
	Thermal Dynamics: 11.0.1
	SmartBrainLib: 1.15
	Drip Sounds: 0.3.2
	VM Translation Update: 4.0.0+mc1.20.1
	Kiwi Library: 11.8.31+forge
	Simple Inventory Sorter: 23.0.8
	Rhino: 2001.2.3-build.10
	FTB Library: 2001.2.9
	Amendments: 1.20-1.2.19
	Berry Good: 7.0.0
	Snad: 20.1.0
	CustomSkinLoader: 14.26.1
	Create: Copycats+: 3.0.2+mc.1.20.1-forge
	Just Enough Items: 15.20.0.112
	Applied Energistics 2: 15.4.4
	Create Low-Heated: 1.20.1-6.0.2-3
	Jess' Painting Collection: 1.19.2
	Underground Beacons: 1.0
	Mekanism: 10.4.16
	KubeJS Thermal: 2001.1.10-build.2
	Decorative Blocks: 4.1.3
	CoFH Core: 11.0.2
	Create: Escalated: 1.1.0
	Table Top Craft: 1.20.1-6.1.2
	GuideME: 20.1.7
	corpsecurioscompat: 3.0.2
	Fusion: 1.2.7+b
	Blueprint: 7.1.3
	AzureLib: 3.0.6
	Chalk: 1.6.6
	Just Enough Immersive Multiblocks: 1.0.4
	Neapolitan: 5.1.0
	Nyf's Spiders: 2.1.1
	CraftingTweaks: 18.2.5
	Tinkers' Construct: 3.10.0.67
	Storage Shelves: 1.0.0
	Simple Voice Chat: 1.20.1-2.5.30
	TerraBlender: 3.0.1.10
	Moonlight Library: 1.20-2.14.1
	Mouse Tweaks: 2.25.1
	Eccentric Tome: 1.20.1-1.10.3
	FTB Quests: 2001.4.13
	Immersive Engineering: 1.20.1-10.2.0-183
	MixinSquared: 0.2.0
	Jade: 11.13.1+forge
	All The Leaks: 0.1.4-beta+1.20.1-forge
	Ceramic Bucket: 1.20.1-4.1.0.0
	Fast Paintings: 1.20-1.2.7
	Ender IO: 6.2.11-beta
	Kotlin For Forge: 4.11.0
	Brewin' And Chewin': 1.20.1-3.2.1
	Mantle: 1.11.55
	Lexiconfig: 1.4.18-1
	BucketLib: 1.20.1-2.3.7.0
	Thermal Cultivation: 11.0.1
	Fast Workbench: 8.0.4
	Storage Drawers: 12.9.14
	AlmostUnified: 1.20.1-0.10.0
	Miner's Delight: 1.20.1-1.2.3
	KubeJS Botania: 1.4.0
	FancyMenu: 3.6.4
	KubeJS Create: 2001.3.0-build.8
	FastFurnace: 8.0.2
	AppleSkin: 2.5.1+mc1.20.1
	Ferrite Core: 6.0.1
	Visuality: Reforged: 2.0.2
	Lychee Tweaker: 5.1.19+forge
	PacketFixer: 3.1.4
	Block Of Sky: 0.3.0
	Simple Radio: 3.4.6
	Create Enchantment Industry: 1.3.2-for-create-6.0.4
	Create Crafts & Additions: 1.20.1-1.3.1

[BirbIrl]

Ah man i'm sorry that we took away the push/pull item functionality, but we can't really mix and match both as far as i'm aware it's impossible without jank. The next best thing is to re-implement all the methods from scratch, like here: cc-tweaked/CC-Tweaked#718

Unless @SquidDev (hope you don't mind the ping) has since made it easier and i just hadn't found a way

[SquidDev]

SyncedPeripheral probably should have an @Override public final Object getTarget() { return blockEntity; }. This will at least allow other peripherals to view the packager as an inventory.

For exposing inventory methods, afraid this isn't any easier, no. Ideally every peripheral would be a GenericPeripheral (which has this composition by default) but it looks like you have custom attach/detach logic, so that's not really possible.

[BirbIrl]

SyncedPeripheral probably should have an @Override public final Object getTarget() { return blockEntity; }. This will at least allow other peripherals to view the packager as an inventory.

Good news and bad news

goods news is, yes, and this works with the stock ticker. You can use peripheral.wrap("left").pullItems("right", 1) and move items from a stock ticker's payment inventory to a barrely or something

bad news is, probably in some way the packager is implemented it just throws Source [whatever] is not an inventory, tripping this in the exact same scenario

Which is really weird, because apparently this worked in the past

Something of note for any brave soldier that wants to tackle this, because i really shouldn't. Anyways as always thanks Squid for chipping in :D

[HKXingluo]

I think adding the new APIs is good because previously I needed an external address decoder, but now I can read the address directly.

However, I can no longer directly transport items inside the packager using
"pushItems" and
"pullItems", which increases system complexity. I now need to add hoppers or other containers for input/output to each packager. Additionally, I have to lock the output device of the packager performing the encoding to keep the packages inside so they can be read.

Therefore, I hope you can bring back the
"pushItems" and
"pullItems" APIs.

I have seen in other projects, such as "https://github.com/gly091020/NetMusicPeripheral" (https://github.com/gly091020/NetMusicPeripheral), where custom APIs are added for peripherals while still enabling item transport operations. I’m not sure how it was done, but perhaps it’s worth looking into.

[BirbIrl]

Thanks for the hint @HKXingluo :D
Here's the code where all the magic happens. It's implemented from scratch. I might try working on this in my spare time, but ive got work and uni now so if anyone else wants to jump on this, probs a good idea to make a PR, ill be sure to review, test it and add the documentation - if anyone implements it