Make Backtank preserve NBT on placement. #6662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #6225
Implemented Solution
This PR saves the item's full nbt data to the backtank block entity, which is then the first thing merged into the root stack.getOrCreateTag() (either via right-click equipping, or the loot table), before the currently saved data overwrites parts of it. Of that data, only Air seems truly relevant still, and the rest could probably be adjusted to just write/read to/from the full nbt, while still making sure already placed backtanks don't lose their enchantments/names. (But that's left out of this PR for now)
Concerns
Any capabilities on the item could probably be saved inside the block entity and restored when picking up the backtank via right-click equipping, but I'm not too sure how they'd be properly preserved from the backtank's loot table. Any ideas on that front would be appreciated.