Fix for https://github.com/Creators-of-Create/Create/issues/7250 #7829
Conversation
Fix for Creators-of-Create#7250 that should hopefully not break anything
Fix for Creators-of-Create#7250 that should hopefully not break anything. Takes the text on the front and back of signs into account.
| for (int i = 0; i < text.size() && i + line < 4; i++) { | ||
| if (i == 0) | ||
| reserve(i + line, sign, context); | ||
| if (i > 0 && isReserved(i + line, sign, context)) | ||
| break; | ||
|
|
||
| signText = signText.setMessage(i + line, text.get(i)); | ||
| //signText = signText.setMessage(i + line, text.get(i)); |
There was a problem hiding this comment.
This can just be removed.
| sign.setText(signText, side); | ||
| context.level() | ||
| .sendBlockUpdated(context.getTargetPos(), sign.getBlockState(), sign.getBlockState(), 2); | ||
| context.level().sendBlockUpdated(context.getTargetPos(), sign.getBlockState(), sign.getBlockState(), 2); |
There was a problem hiding this comment.
You should set the text before telling the level the block got updated.
There was a problem hiding this comment.
Okay.
I am now wondering... Do both sides of the sign need their own sendBlockUpdate(), or can we get away with only one?
There was a problem hiding this comment.
One is enough. The previous code only called it once. And please wrap the part of the changes after if (changed) into {}
- Removed unused import statement.
- Wrapped all code in the if statements with {}.
- Removed a seemingly unnecessary `sendBlockUpdated`.
| SignText signTextFront = ((SignBlockEntity) be).getFrontText(); | ||
| SignText signTextBack = ((SignBlockEntity) be).getBackText(); |
There was a problem hiding this comment.
Wouldn't that be better?
| SignText signTextFront = ((SignBlockEntity) be).getFrontText(); | |
| SignText signTextBack = ((SignBlockEntity) be).getBackText(); | |
| SignText signTextFront = sign.getFrontText(); | |
| SignText signTextBack = sign.getBackText(); |
There was a problem hiding this comment.
Also you don't need {} in every if statement, just in the if (changed) { ... }
|
Does this also fix the issue where the sign's data was completely cleared when the text got updated? |
As far as I can tell, yes. This fix preserves both the text on the sign and any dyes that were applied. |
"Fine, I'll do it myself." - Thanos
This is a fix for #7250 that takes text on the front and back of signs into account