Increase ElevatorPulley view distance to 512 #7852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g correctly while style switching Found the issue while adding custom bogeys. The bogeys wouldn't update their lighting while switching styles, occurred with the standard bogeys also. Probably was overlooked because Create only has one style. Thanks to Roselle for solving this issue.
- Add glass pipe visual, fluid instance, and fluid mesh - Just pipes for now, tanks need more thought as the same visual is used for boilers
|
@KCreate, this pull request is targeting the wrong branch. Pull requests should target the branch corresponding to the earliest supported Minecraft version unless the changes are specific to code that only exists for a newer Minecraft version. Please change the target branch, resolve any merge conflicts, and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks! |
VoidLeech
added
pr type: fix
|
Closing this and opening a new PR since I messed up the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change increases the view distance of the elevator pulley to 512. This ensures that the elevator pulley is always visible and doesn't disappear whenever the elevator drops below 128 blocks.
This is my first interaction with the Create codebase, please tell me if this change wouldn't have the effect I'm expecting it to have.
Feedback is greatly appreciated.