Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-ify Datagen #7861

Open
wants to merge 4 commits into
base: mc1.20.1/dev
Choose a base branch
from

Conversation

ChiefArug
Copy link

This refactors datagen into an API that addons can make use of without the overhead of also running all of Creates stuff.

This splits each current datagen class into a base class in the api package, which contains things like the recipe type, the generation logic and most of the helper methods, and a final class in Create's data package which contains all the actual generation and any helper methods that make use of the Mod enum (my original plan was to weaken that to package-private as it is inextensible and therefore bad for addons to be using, however despite being in the data package it is used in many places outside that for hardcoded mod compat).

Fixes #7366
Conflicts with #7084, one of these will need editing after the other gets merged.

@ChiefArug
Copy link
Author

This is a massive breaking change, however it shouldn't actually break addons at runtime, only in dev.

@VoidLeech VoidLeech added area: api Issue or PR is related to API pr type: feature PR adds a new feature or changes an existing feature labels Mar 9, 2025
@VoidLeech VoidLeech requested review from zelophed and removed request for zelophed March 9, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Issue or PR is related to API pr type: feature PR adds a new feature or changes an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split datagen into api and Create's actual datagen
2 participants