-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(internal): add manual demo and link for manual testing #81
chore(internal): add manual demo and link for manual testing #81
Conversation
This allows testing colors, contrast, interaction, etc
@@ -57,6 +57,26 @@ pnpm run build:preview | |||
npx http-server ./dist | |||
``` | |||
|
|||
Note that changes to config or build scripts will require re-running `pnpm start`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I would link out to the build and config folders.
I also think that this could use some added emphasis like
🗒️ Note:
because it's something people easily forget. But again just a suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
but how would we say build = lib folder (easy part) -- maybe we just rename this to build and then link.
and then for config, it's.. every other js file?
Maybe I can have a go at making the organization of this repo making more sense in a followup PR 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe like config files like <example config file>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm. alright, I dig it.
I'll throw something together once #84 is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This allows testing colors, contrast, interaction, etc
Why
We need an easy demo page for manually testing accessibility of our colors / styles.
Someone "needing to test something real quick" can add / edit the
manual-test.html
to set up their scenario and observe how it looks in both light and dark mode.Test Plan
(at least until I get preview URLs working from forks, see exploration here: #62)
git clone https://github.com/NullVoxPopuli/tailwind-toucan-base.git
cd tailwind-toucan-base
git checkout add-manual-demo-page
pnpm install
pnpm start
this may also be directly visited via
http://localhost:8080/manual
When deployed, this'll be at https://tailwind-toucan-base.pages.dev/manual