Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal): add manual demo and link for manual testing #81

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 28, 2022

This allows testing colors, contrast, interaction, etc

Why

We need an easy demo page for manually testing accessibility of our colors / styles.

Someone "needing to test something real quick" can add / edit the manual-test.html to set up their scenario and observe how it looks in both light and dark mode.

Test Plan

(at least until I get preview URLs working from forks, see exploration here: #62)

  1. git clone https://github.com/NullVoxPopuli/tailwind-toucan-base.git
  2. cd tailwind-toucan-base
  3. git checkout add-manual-demo-page
  4. pnpm install
  5. pnpm start
  6. visit http://localhost:8080
  7. see link at the top: image
  8. see page: image
    this may also be directly visited via http://localhost:8080/manual

When deployed, this'll be at https://tailwind-toucan-base.pages.dev/manual

This allows testing colors, contrast, interaction, etc
@NullVoxPopuli NullVoxPopuli requested a review from a team June 28, 2022 19:05
@nicolechung
Copy link
Contributor

Works for me.

Terminal prompted a non-localhost address:
Screen Shot 2022-06-28 at 4 36 05 PM
Screen Shot 2022-06-28 at 4 36 25 PM

BUT when I went to localhost I saw the Crowdstrike branded version

@@ -57,6 +57,26 @@ pnpm run build:preview
npx http-server ./dist
```

Note that changes to config or build scripts will require re-running `pnpm start`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I would link out to the build and config folders.

I also think that this could use some added emphasis like

🗒️ Note:

because it's something people easily forget. But again just a suggestion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

but how would we say build = lib folder (easy part) -- maybe we just rename this to build and then link.
and then for config, it's.. every other js file?

Maybe I can have a go at making the organization of this repo making more sense in a followup PR 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe like config files like <example config file>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm. alright, I dig it.
I'll throw something together once #84 is merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#89

Copy link
Contributor

@nicolechung nicolechung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NullVoxPopuli NullVoxPopuli merged commit 65a6aca into CrowdStrike:main Jun 28, 2022
@NullVoxPopuli NullVoxPopuli deleted the add-manual-demo-page branch June 28, 2022 20:46
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants