Skip to content

feat: invalidate DSPM and vulnerability scanning computed default role names when prefix/suffix are changed#289

Draft
cs-wayne-hsieh wants to merge 4 commits into
mainfrom
CSPG-72361-add-prefix-suffix-to-dspm-vul-scan-default-role-name
Draft

feat: invalidate DSPM and vulnerability scanning computed default role names when prefix/suffix are changed#289
cs-wayne-hsieh wants to merge 4 commits into
mainfrom
CSPG-72361-add-prefix-suffix-to-dspm-vul-scan-default-role-name

Conversation

@cs-wayne-hsieh
Copy link
Copy Markdown
Contributor

@cs-wayne-hsieh cs-wayne-hsieh commented Feb 12, 2026

Summary

  • Invalidate DSPM and vulnerability scanning role name fields when resource_name_prefix or resource_name_suffix changes, so the API-computed default role names are refreshed
  • Remove redundant writes to m.DSPM.RoleName and m.VulnerabilityScanning.RoleName in wrap() that were overwriting the sub-block state with the already-set top-level values

Test plan

  • Verify that changing resource_name_prefix or resource_name_suffix triggers a plan diff for DSPM and vulnerability scanning role names
  • Verify that DSPM and vulnerability scanning role names correctly reflect the prefix/suffix after apply
  • Run existing acceptance tests for cloud_aws_account

Issue: CSPG-72361

@cs-wayne-hsieh cs-wayne-hsieh changed the title feat: add prefix/suffix to DSPM and vulnerability scanning default role names feat: invalidate DSPM and vulnerability scanning computed default role names when prefix/suffix are changed Feb 12, 2026
Comment thread internal/fcs/cloud_aws_account.go
Comment thread internal/fcs/cloud_aws_account.go Outdated
Comment thread internal/fcs/cloud_aws_account_test.go Outdated
@ffalor
Copy link
Copy Markdown
Contributor

ffalor commented Mar 16, 2026

@cs-wayne-hsieh any eta on when we should merge this?

@cs-wayne-hsieh
Copy link
Copy Markdown
Contributor Author

cs-wayne-hsieh commented Mar 17, 2026

@ffalor Not yet, still waiting for response of some issues. Do you want me to convert it to draft for now?

@ffalor ffalor marked this pull request as draft March 17, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants