feat: add data protection policy resource#306
Open
GrantBirki wants to merge 4 commits into
Open
Conversation
ffalor
reviewed
Mar 2, 2026
Contributor
Author
|
@ffalor another one! |
Contributor
|
This is being worked on, its just very large and I'm finding some api behavior that is just taking a little bit to validate. I've approved 2 of your others and will be merged once someone on my team is able to review my changes. the ml cert exclusion I'm also almost done going through. |
ffalor
added a commit
to CrowdStrike/gofalcon
that referenced
this pull request
Apr 9, 2026
Make 13 boolean fields in policymanager.PolicyProperties nullable (*bool) so false can be explicitly sent via PATCH API. Previously, omitempty on value-type bool caused false to be silently omitted, making it impossible to toggle fields from true to false. Also make precedence optional and nullable in ExternalPolicyPatch and ExternalPolicyPost since it is not required by the API and 0 is a valid value. Remove enable_content_inspection from the required list as it is also optional. Ref: CrowdStrike/terraform-provider-crowdstrike#306
redhatrises
pushed a commit
to CrowdStrike/gofalcon
that referenced
this pull request
May 4, 2026
Make 13 boolean fields in policymanager.PolicyProperties nullable (*bool) so false can be explicitly sent via PATCH API. Previously, omitempty on value-type bool caused false to be silently omitted, making it impossible to toggle fields from true to false. Also make precedence optional and nullable in ExternalPolicyPatch and ExternalPolicyPost since it is not required by the API and 0 is a valid value. Remove enable_content_inspection from the required list as it is also optional. Ref: CrowdStrike/terraform-provider-crowdstrike#306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
crowdstrike_data_protection_policyresource for Falcon Data Protection policy management in Terraform, including provider registration, sweeper support, examples, generated docs, and acceptance, unit, schema, and sweep test coverage. It also addresses review feedback by treating payload-level404responses as not found duringRead()and by making legacy policy sweeps try bothwinandmacfallback platforms.Resolves: #284