feat(container_registry): add container_registry resource and data source#354
Open
seiji wants to merge 7 commits into
Open
feat(container_registry): add container_registry resource and data source#354seiji wants to merge 7 commits into
seiji wants to merge 7 commits into
Conversation
Add crowdstrike_container_registry resource and data source for managing container registry connections in CrowdStrike Falcon Container Security. Supports 17 registry types (dockerhub, ecr, acr, gar, gcr, github, etc.) with type-specific credential validation via ValidateConfig. Workaround for gofalcon treating HTTP 200 as error on Create: falls back to findRegistryByURL (URL + type + user_defined_alias matching) to locate the created entity.
Author
|
Fixed the lint errors. 1851a4c Could you take another look when you have a chance? |
Author
|
This PR was not necessarily intended to request a merge, but rather to highlight the operational need for this functionality. I would appreciate it if you could consider this capability for future product implementation or roadmap discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
crowdstrike_container_registryresource andcrowdstrike_container_registrydata source for managing container registry connections in CrowdStrike Falcon Container Security.Closes #312
What's included
crowdstrike_container_registryresource — full CRUD lifecycle with import supportcrowdstrike_container_registrydata source — look up a registry by IDDesign decisions
ValidateConfigcredentialis defined asSingleNestedAttribute(not a block) to allowRequiredconstraint and null/unknown handlingfindRegistryByURL(URL + type + user_defined_alias matching) to locate the created entityImportStateVerifyIgnoreRequiresReplaceTesting
TestAccContainerRegistryResource_DockerHub— Create, update credential, importTestAccContainerRegistryDataSource_basic— Read by ID (requiresTEST_CONTAINER_REGISTRY_ID)Checklist