Skip to content

fix(cloudgoogleregistration) - CSPG-92054 on create merge put and patch to put only#403

Merged
ffalor merged 1 commit into
mainfrom
fix/zzango/CSPG-92054/google-registration-create-one-request
Jun 3, 2026
Merged

fix(cloudgoogleregistration) - CSPG-92054 on create merge put and patch to put only#403
ffalor merged 1 commit into
mainfrom
fix/zzango/CSPG-92054/google-registration-create-one-request

Conversation

@zango88
Copy link
Copy Markdown
Contributor

@zango88 zango88 commented Jun 2, 2026

Summary

  • Consolidated the GCP registration create flow into a single PUT request by moving FalconClientKeyID and WifProjectNumber params directly into createReq, eliminating the separate PATCH call (CloudRegistrationGcpUpdateRegistration) that was previously needed after creation.
  • FalconClientKeyID is now always included in the create request.
  • WifProjectNumber is conditionally included when set (non-null).

Test plan

  • All acceptance tests passed against EU-1:
    • TestAccCloudGoogleRegistrationResource_Complete
    • TestAccCloudGoogleRegistrationResource_Project
    • TestAccCloudGoogleRegistrationResource_Organization
    • TestAccCloudGoogleRegistrationResource_RealtimeVisibility
    • TestAccCloudGoogleRegistrationResource_RequiresReplace
    • TestAccCloudGoogleRegistrationResource_RemoveResourceNamePrefixAndSuffix
    • TestAccCloudGoogleRegistrationResource_InfrastructureManagerMissingRegion
    • TestAccCloudGoogleRegistrationResource_ExcludedProjectPatternsValidation
    • TestAccCloudGoogleRegistrationSettingsResource_Basic
    • TestAccCloudGoogleRegistrationSettingsResource_IOANotEnabled

@zango88 zango88 requested review from erez-bashari and ffalor June 2, 2026 09:23
@zango88 zango88 self-assigned this Jun 2, 2026
@zango88 zango88 changed the title fix(cloudgoogleregistration) - on create merge put and patch to put only fix(cloudgoogleregistration) - CSPG-92054 on create merge put and patch to put only Jun 2, 2026
@ffalor ffalor merged commit fcca72f into main Jun 3, 2026
11 checks passed
@ffalor ffalor deleted the fix/zzango/CSPG-92054/google-registration-create-one-request branch June 3, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants