En/117 Upgrade proxy to aws 7.0 api #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 36.89% 36.84% -0.05%
==========================================
Files 23 23
Lines 1827 1767 -60
Branches 379 406 +27
==========================================
- Hits 674 651 -23
+ Misses 924 880 -44
- Partials 229 236 +7
|
vishakh
reviewed
Feb 29, 2024
| @@ -1,25 +1,27 @@ | |||
| [package] | |||
| name = "nft_image_proxy" | |||
| version = "2.0.0" | |||
| version = "1.5.0" | |||
There was a problem hiding this comment.
main branch was on an upgrade path. Nothing breaking was merged to it nor was a release done of it, so it was deemed a reasonable starting point for the current aws changes. Hence the bump down.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "url": "http://localhost:3000", | |||
| "url": "http://127.0.0.1:3000", | |||
There was a problem hiding this comment.
npm has started resolving localhost to ipv6 addresses. Proxy doesn't support ipv6 yet.
SiddharthV1
previously approved these changes
Mar 1, 2024
SiddharthV1
approved these changes
Mar 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to ticket #117 , closes #79
PR includes: