-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend OOVPA Tests #154
base: master
Are you sure you want to change the base?
Extend OOVPA Tests #154
Conversation
@@ -110,7 +110,7 @@ static bool CompareOOVPAToAddress(iXbSymbolContext* pContext, OOVPA* Oovpa, memp | |||
// Return if the given (XRef'erenced) is not set yet. | |||
static inline bool internal_IsXRefUnset(uint16_t XRef) | |||
{ | |||
return (XRef == (uint16_t)XREF_ADDR_UNDETERMINED) || (XRef == XREF_ADDR_DERIVE); | |||
return (XRef == XREF_UNDETERMINED) || (XRef <= XREF_KT_COUNT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the second test changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal_IsXRefUnset
is intended to check if xref is set for database's symbols that are grouped together. Plus cannot have kernel thunk references from the database's symbols. So, that's consider as not set. There's two difference between internal_IsXRefUnset
and internal_IsXRefAddrUnset
. internal_IsXRefAddrUnset
is designed for check xref_database's array that is cached.
Review remarks are currently welcome at this time and any new internal tests as well.
Reasons this pull request is draft:
List of self-tests added:
List of below is pretty much rules should be follow which will be likely copy over to wiki page.
stdcall
symbol is used, then it require to be normal name unless later API has changed to add / remove parameter._#
suffix is required.__r1
suffix or the like. This decision had not been made.CDirectSoundStream_GetStatus
as an example does not fall under this category. Since the internal function had changed a bit.__LTCG
suffix is required along with which parameters are assigned to either onto stack or registers. We only need registers assigned, parameters on the stack is not a requirement.List of current reports as of commit d60c19a
SymbolDatabaseVerifyContext_VerifyXRefJmp:
SymbolDatabaseVerifyContext_VerifySymbolDuplicate: