Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global update interval as the default for update sources #1428

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/models/base/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,9 @@ export type UpdateConfig = {
/** Custom delimiter definition */
custom_delimiter?: string;

/** Default pattern for finding signatures*/
default_pattern: string

/** Does the updater produce signatures? */
generates_signatures: boolean;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const WrappedSourceDialog = ({ open, setOpen, source = null, defaults, onSave }:
<DialogContent>
<SourceDetail
source={tempSource}
addMode={!source}
addMode={!source?.name}
defaults={defaults}
setSource={setTempSource}
setModified={setModified}
Expand Down
16 changes: 14 additions & 2 deletions src/components/routes/admin/service_detail/updater.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import {
useTheme
} from '@mui/material';
import FormControl from '@mui/material/FormControl';
import { Service, UpdateSource } from 'components/models/base/service';
import useALContext from 'components/hooks/useALContext';
import { DEFAULT_SOURCE, Service, UpdateSource } from 'components/models/base/service';
import { SourceCard } from 'components/routes/manage/signature_sources';
import { useEffect, useState } from 'react';
import { useTranslation } from 'react-i18next';
Expand Down Expand Up @@ -57,6 +58,7 @@ const marks = [

const ServiceUpdater = ({ service, defaults, setService, setModified }: ServiceUpdaterProps) => {
const { t } = useTranslation(['adminServices']);
const { c12nDef } = useALContext();
const [dialog, setDialog] = useState<boolean>(false);
const [editDialog, setEditDialog] = useState<boolean>(false);
const [editedSourceID, setEditedSourceID] = useState(-1);
Expand Down Expand Up @@ -365,7 +367,17 @@ const ServiceUpdater = ({ service, defaults, setService, setModified }: ServiceU
</Grid>

<Grid item xs={12}>
<SourceDialog open={dialog} setOpen={setDialog} onSave={handleSaveSource} />
<SourceDialog
open={dialog}
source={{
...DEFAULT_SOURCE,
update_interval: service.update_config.update_interval_seconds,
default_classification: c12nDef.UNRESTRICTED,
pattern: service.update_config.default_pattern
}}
setOpen={setDialog}
onSave={handleSaveSource}
/>
<Button variant="contained" color="primary" onClick={() => setDialog(true)}>
{t('updater.sources.add')}
</Button>
Expand Down
67 changes: 56 additions & 11 deletions src/components/routes/manage/signature_sources.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,18 @@ const queueSourceUpdate = (source: UpdateSource) => ({
type SourceDetailDrawerProps = {
service: string;
base: UpdateSource;
defaults: UpdateSource;
generatesSignatures: UpdateConfig['generates_signatures'];
onClose?: () => void;
};

const WrappedSourceDetailDrawer = ({ service, base, onClose, generatesSignatures }: SourceDetailDrawerProps) => {
const WrappedSourceDetailDrawer = ({
service,
base,
defaults,
onClose,
generatesSignatures
}: SourceDetailDrawerProps) => {
const { t } = useTranslation(['manageSignatureSources']);
const theme = useTheme();
const { apiCall } = useMyAPI();
Expand All @@ -168,13 +175,13 @@ const WrappedSourceDetailDrawer = ({ service, base, onClose, generatesSignatures

const saveChanges = () => {
apiCall({
method: base ? 'POST' : 'PUT',
url: base
method: base?.name ? 'POST' : 'PUT',
url: base?.name
? `/api/v4/signature/sources/${service}/${encodeURIComponent(source.name)}/`
: `/api/v4/signature/sources/${service}/`,
body: source,
onSuccess: () => {
showSuccessMessage(t(base ? 'change.success' : 'add.success'));
showSuccessMessage(t(base?.name ? 'change.success' : 'add.success'));
setModified(false);
if (!base || !isXL) onClose();
setTimeout(() => window.dispatchEvent(new CustomEvent('reloadUpdateSources')), 1000);
Expand Down Expand Up @@ -324,8 +331,8 @@ const WrappedSourceDetailDrawer = ({ service, base, onClose, generatesSignatures
</div>
<SourceDetail
source={source}
defaults={null}
addMode={!base}
defaults={defaults}
addMode={!base?.name}
setSource={setSource}
setModified={setModified}
showDetails={false}
Expand Down Expand Up @@ -503,12 +510,21 @@ type ServiceDetailProps = {
service: string;
sources: UpdateConfig['sources'];
generatesSignatures: UpdateConfig['generates_signatures'];
updateIntervalSeconds: UpdateConfig['update_interval_seconds'];
defaultPattern: UpdateConfig['default_pattern'];
};

const ServiceDetail = ({ service, sources, generatesSignatures }: ServiceDetailProps) => {
const ServiceDetail = ({
service,
sources,
generatesSignatures,
updateIntervalSeconds,
defaultPattern
}: ServiceDetailProps) => {
const { t } = useTranslation(['manageSignatureSources']);
const theme = useTheme();
const classes = useStyles();
const { c12nDef } = useALContext();
const { apiCall } = useMyAPI();
const { closeGlobalDrawer, setGlobalDrawer } = useDrawer();
const { showSuccessMessage } = useMySnackbar();
Expand All @@ -527,11 +543,12 @@ const ServiceDetail = ({ service, sources, generatesSignatures }: ServiceDetailP
});
};

const openDrawer = useCallback((currentService: string, source) => {
const openDrawer = useCallback((currentService: string, source, defaults) => {
setGlobalDrawer(
<SourceDetailDrawer
service={currentService}
base={source}
defaults={defaults}
generatesSignatures={generatesSignatures}
onClose={closeGlobalDrawer}
/>
Expand Down Expand Up @@ -561,7 +578,22 @@ const ServiceDetail = ({ service, sources, generatesSignatures }: ServiceDetailP
color: theme.palette.mode === 'dark' ? theme.palette.success.light : theme.palette.success.dark,
margin: '-4px 0'
}}
onClick={() => openDrawer(service, null)}
onClick={() =>
openDrawer(
service,
{
...DEFAULT_SOURCE,
update_interval: updateIntervalSeconds,
default_classification: c12nDef.UNRESTRICTED,
pattern: defaultPattern
},
{
update_interval: updateIntervalSeconds,
default_classification: c12nDef.UNRESTRICTED,
pattern: defaultPattern
}
)
}
size="large"
>
<AddCircleOutlineOutlinedIcon />
Expand Down Expand Up @@ -610,7 +642,7 @@ const ServiceDetail = ({ service, sources, generatesSignatures }: ServiceDetailP
key={id}
source={source}
service={service}
onClick={() => openDrawer(service, source)}
onClick={() => openDrawer(service, source, source)}
generatesSignatures={generatesSignatures}
/>
))
Expand All @@ -623,7 +655,18 @@ const ServiceDetail = ({ service, sources, generatesSignatures }: ServiceDetailP
</Collapse>
</div>
),
[classes.title, generatesSignatures, open, openDrawer, service, sources, t, theme, triggerSourceUpdateAll]
[
classes.title,
generatesSignatures,
open,
openDrawer,
service,
sources,
t,
theme,
triggerSourceUpdateAll,
updateIntervalSeconds
]
);
};

Expand Down Expand Up @@ -674,6 +717,8 @@ export default function SignatureSources() {
service={key}
sources={sources[key].sources}
generatesSignatures={sources[key].generates_signatures}
updateIntervalSeconds={sources[key].update_interval_seconds}
defaultPattern={sources[key].default_pattern}
/>
))
: [...Array(2)].map((item, i) => (
Expand Down