Skip to content

ci: test macos latest #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: test macos latest #802

wants to merge 2 commits into from

Conversation

jkowalleck
Copy link
Member

No description provided.

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck added the CI Continuous Integration label Mar 23, 2025
@jkowalleck jkowalleck requested a review from a team as a code owner March 23, 2025 12:52
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jkowalleck, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the GitHub Actions workflow configuration file (.github/workflows/python.yml) to test the code against the latest macOS version. It replaces macos-13 with macos-latest in the matrix of operating systems. Additionally, it introduces an exclude section to prevent testing Python 3.8 on macos-latest due to potential incompatibility issues, and an include section to specifically test Python 3.8 on macos-13 with both -allExtras and -noExtras toxenv-factors.

Highlights

  • macOS Testing: The PR updates the CI configuration to test against macos-latest instead of macos-13.
  • Python 3.8 Compatibility: The PR excludes Python 3.8 from running on macos-latest due to potential incompatibilities and includes specific configurations for Python 3.8 on macos-13.
  • Tox Environment Factors: The PR ensures that Python 3.8 is tested with both -allExtras and -noExtras toxenv-factors on macos-13.

Changelog

  • .github/workflows/python.yml
    • Replaced macos-13 with macos-latest in the os matrix.
    • Added an exclude section to prevent testing Python 3.8 on macos-latest.
    • Added an include section to specifically test Python 3.8 on macos-13 with -allExtras and -noExtras toxenv-factors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


The matrix spins, the tests all run,
On macOS, Python's work is done.
Latest version, a brand new quest,
To find the bugs and put them to the test.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the GitHub Actions workflow to test the project against the latest macOS version. The changes involve modifying the matrix strategy to include macos-latest and adjusting the Python version compatibility for macOS. Overall, the changes seem reasonable, but there are a few points to consider.

Summary of Findings

  • macOS Python 3.8 Compatibility: The PR addresses potential incompatibility issues between macos-latest and Python 3.8 by excluding this combination and including specific configurations for macos-13 with Python 3.8. This approach seems reasonable but should be carefully monitored for any unexpected behavior.
  • Clarity of Exclude/Include Logic: The exclude and include sections in the matrix configuration could benefit from additional comments or documentation to clarify the reasoning behind these specific configurations. This would improve the maintainability of the workflow.

Merge Readiness

The changes appear to be well-structured and address a specific issue. However, it's recommended to monitor the test results on macos-latest closely after merging to ensure compatibility and stability. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant