feat/cardano: transaction signing flow#180
Conversation
Signed-off-by: Prashant Rahul <prashantrahul141@protonmail.com>
|
| let signedTransaction: ISignedTransaction | undefined; | ||
|
|
||
| if (params.serializeTxn) { | ||
| signedTransaction = { |
There was a problem hiding this comment.
This is not the serialized transaction. Either remove this or create an actual serialized txn
| // eslint-disable-next-line camelcase | ||
| raw_data: any; | ||
| // eslint-disable-next-line camelcase | ||
| raw_data_hex: string; |
There was a problem hiding this comment.
why not camelcase?
There was a problem hiding this comment.
I saw that this was how it was done in one of the other apps, fixed
| visible?: boolean; | ||
| txID: string; | ||
| // eslint-disable-next-line camelcase | ||
| raw_data: any; |
There was a problem hiding this comment.
what is the use of these?
| assertOrThrowInvalidResult(confirmation); | ||
| forceStatusUpdate(SignTxnEvent.CONFIRM); | ||
|
|
||
| await helper.sendInChunks(txnBytes, 'txnData', 'dataAccepted'); |
There was a problem hiding this comment.
Will have to evaluate this. Either ask the software using sdk to send only the required part of the txn which just the txn body OR decode here only in sdk and only send the txn body to firmware
prashantrahul141
force-pushed
the
feat/cardano/txn-signing
branch
from
95d5cba to
6d7fda4
Compare
|
|
||
| export interface IUnsignedTransaction { | ||
| visible?: boolean; | ||
| txID: string; |
| walletId: Uint8Array; | ||
| derivationPath: number[]; | ||
| txn: IUnsignedTransaction; | ||
| serializeTxn?: boolean; |
Signed-off-by: Prashant Rahul <prashantrahul141@protonmail.com>
prashantrahul141
force-pushed
the
feat/cardano/txn-signing
branch
from
6d7fda4 to
6f403f6
Compare
2 participants
No description provided.