-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSR-1387 - upgrade node to 20 #899
Open
neilbmclaughlin
wants to merge
11
commits into
development
Choose a base branch
from
fix/FSR-1387-upgrade-node
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeGordon83
approved these changes
Feb 3, 2025
neilbmclaughlin
force-pushed
the
fix/FSR-1387-upgrade-node
branch
3 times, most recently
from
February 3, 2025 17:18
8b231b2
to
c6bb8b0
Compare
Note: couldn't go to 22 as hapi-rate-limit is not supported in 22
This is to support consistency across environments. Need to ensure this value matches the value in .nvmrc
There is nothing bash dependent in the scripts and switching to sh allows more portability (relevant when using docker alpine images)
* precursor to installing the correct version
neilbmclaughlin
force-pushed
the
fix/FSR-1387-upgrade-node
branch
from
February 5, 2025 15:20
36a2cc9
to
91f1fd7
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: see related changes to the Jenkins build pipeline here