Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSR-1387 - upgrade node to 20 #899

Open
wants to merge 11 commits into
base: development
Choose a base branch
from

Conversation

neilbmclaughlin
Copy link
Contributor

@neilbmclaughlin neilbmclaughlin commented Jan 28, 2025

  • FSR-1387-upgrade-node
  • Refine start scripts to allow better watching and simple start
  • Switch from unsupported @hapi/joi to joi as recomended
  • Update node engine

Note: see related changes to the Jenkins build pipeline here

@neilbmclaughlin neilbmclaughlin marked this pull request as ready for review January 28, 2025 17:35
@neilbmclaughlin neilbmclaughlin force-pushed the fix/FSR-1387-upgrade-node branch 3 times, most recently from 8b231b2 to c6bb8b0 Compare February 3, 2025 17:18
Note: couldn't go to 22 as hapi-rate-limit is not supported in 22
This is to support consistency across environments. Need to ensure this
value matches the value in .nvmrc
There is nothing bash dependent in the scripts and switching to sh
allows more portability (relevant when using docker alpine images)
* precursor to installing the correct version
@neilbmclaughlin neilbmclaughlin force-pushed the fix/FSR-1387-upgrade-node branch from 36a2cc9 to 91f1fd7 Compare February 5, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants