Add new TPT supplementary batch type #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4201 > Part of the work to support two-part tariff bill runs We are working on adding support for two-part tariff supplementary bill runs to the service. We've [spiked the logic](DEFRA/water-abstraction-system#1412) to understand how we can do this, but when doing it was being flagged as an error. No errors were thrown within [water-abstraction-system](https://github.com/DEFRA/water-abstraction-system), so we took a look at this project. That's when we spotted, after triggering `src/modules/billing/jobs/refresh-totals.js` an error was being thrown. This was because of the previous teams decision to validate all data both to and from the DB, and it not knowing about the new `two_part_supplementary` batch type.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4201
We are working on adding support for two-part tariff supplementary bill runs to the service. We've spiked the logic to understand how we can do this, but when doing it was being flagged as an error.
No errors were thrown within water-abstraction-system, so we looked at this project. That's when we spotted, after triggering
src/modules/billing/jobs/refresh-totals.js, an error was being thrown. This was because of the previous team's decision to validate all data both to and from the DB, and it not knowing about the newtwo_part_supplementarybatch type.