Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Hapi Lab with node-test for test runner #1589

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,13 @@ jobs:

- name: Run unit tests
run: |
npm test
npm run pretest
npm run test:lcov

- name: Code coverage
uses: livewing/[email protected]
with:
lcov: coverage/lcov.info
lcov: lcov.info

- name: Analyze with SonarQube
if: github.actor != 'dependabot[bot]'
Expand Down
67 changes: 0 additions & 67 deletions .labrc.js

This file was deleted.

8 changes: 5 additions & 3 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

const jsdocPlugin = require('eslint-plugin-jsdoc')
const eslintPluginPrettierRecommended = require('eslint-plugin-prettier/recommended')
const globals = require('globals')
const neostandard = require('neostandard')

module.exports = [
Expand All @@ -26,9 +25,12 @@ module.exports = [
languageOptions: {
ecmaVersion: 'latest',
// Needed so ESlint knows it is checking Node code. For example, without it all uses of `console.log()` and
// `process.env()` would be flagged by the 'no-undef' rule
// `process.env()` would be flagged by the 'no-undef' rule.
// The source for how to set this we took from https://github.com/sindresorhus/globals/blob/main/globals.json
// and https://eslint.org/docs/latest/use/configure/language-options#predefined-global-variables
globals: {
...globals.node
console: 'readable',
process: 'readable'
},
sourceType: 'commonjs'
},
Expand Down
Loading
Loading