Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new quarterly return versions for water companies #1648

Merged
merged 10 commits into from
Jan 30, 2025

Conversation

robertparkinson
Copy link
Collaborator

https://eaflood.atlassian.net/browse/WATER-4881

As part of our work in setting up quarterly returns for water companies we need to run a one off migration for each of them to create a new return version. This PR creates an end point that can be hit as part of a job. It will loop through each of the water companies that do not have a return version starting next year and create one.

@robertparkinson robertparkinson marked this pull request as draft January 23, 2025 16:21
@robertparkinson robertparkinson self-assigned this Jan 23, 2025
@robertparkinson robertparkinson marked this pull request as ready for review January 28, 2025 11:04
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stopped when I got to FetchWaterUndertakersService for the reasons stated. If I've misunderstood how the code works though do feel free to put me right!

app/controllers/jobs.controller.js Outdated Show resolved Hide resolved
app/controllers/jobs.controller.js Outdated Show resolved Hide resolved
app/routes/jobs.routes.js Outdated Show resolved Hide resolved
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small change, and its all my fault!

@robertparkinson robertparkinson merged commit 82a3c82 into main Jan 30, 2025
6 of 7 checks passed
@robertparkinson robertparkinson deleted the return-version-one-off-migration branch January 30, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants