-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new quarterly return versions for water companies #1648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stopped when I got to FetchWaterUndertakersService
for the reasons stated. If I've misunderstood how the code works though do feel free to put me right!
app/services/jobs/return-logs/fetch-water-undertakers.service.js
Outdated
Show resolved
Hide resolved
app/services/jobs/return-logs/return-version-migration.service.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more small change, and its all my fault!
app/services/jobs/return-logs/fetch-water-undertakers.service.js
Outdated
Show resolved
Hide resolved
…ater-abstraction-system into return-version-one-off-migration
https://eaflood.atlassian.net/browse/WATER-4881
As part of our work in setting up quarterly returns for water companies we need to run a one off migration for each of them to create a new return version. This PR creates an end point that can be hit as part of a job. It will loop through each of the water companies that do not have a return version starting next year and create one.