Move reusable two-part tariff billing services #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4201 > Part of the work to support two-part tariff supplementary bill runs In [Move reusable supplementary billing services](#1760) we shifted some existing supplementary billing services to make them resuable by the two-part tariff supplementary billing engine we're building. Our [spike](#1412) has shown there are some two-part tariff annual billing services we can also make reusable.
This is where all the work of a billing engine happens. That change is out of scope for what we are doing in this change. So, we'll fill it out later. For now, this allows us to confirm that our changes to the generate service are working as expected, and it knows which process billing period service to call.
Cruikshanks
added
the
housekeeping
Cruikshanks
added a commit
that referenced
this pull request
Mar 3, 2025
https://eaflood.atlassian.net/browse/WATER-4201 > Part of the work to support two-part tariff supplementary bill runs In [Move reusable supplementary billing services](#1760) we shifted some existing supplementary billing services to make them reusable by the two-part tariff supplementary billing engine we're building. Then we spotted [some two-part tariff billing services we could remove and reuse](#1765). The final step of supporting two-part tariff supplementary, like standard supplementary, is the flagging. When changes are made to licences they are flagged for supplementary billing, and it is these 'flags' that drive whether a licence is considered as part of a supplementary bill run. Just as complex as setting the flags, is unsetting them. There are various actions, either driven by the users or from logic in the engines, that triggers licences becoming unflagged. Two scenarios a two-part tariff supplementary shares with a standard supplementary, are - when a licence after processing is found _not_ to have generated a bill - when the bill has been sent and the licence can be considered as having been 'processed' for supplementary billing We already have services that handle these scenarios, which are called at the appropriate times. So, ahead of adding the two-part tariff supplementary flagging logic, we move the existing services ready for reuse.
Cruikshanks
added a commit
that referenced
this pull request
Mar 3, 2025
https://eaflood.atlassian.net/browse/WATER-4201 > Part of the work to support two-part tariff supplementary bill runs In [Move reusable supplementary billing services](#1760) we shifted some existing supplementary billing services to make them reusable by the two-part tariff supplementary billing engine we're building. Then we spotted [some two-part tariff billing services we could remove and reuse](#1765). The final step of supporting two-part tariff supplementary, like standard supplementary, is the flagging. When changes are made to licences, they are flagged for supplementary billing, and it is these 'flags' that drive whether a licence is considered part of a supplementary bill run. Just as complex as setting the flags is unsetting them. Various actions, either driven by the users or from logic in the engines, trigger licences becoming unflagged. Two scenarios a two-part tariff supplementary shares with a standard supplementary, are - when a licence after processing is found _not_ to have generated a bill - when the bill has been sent and the licence can be considered as having been 'processed' for supplementary billing We already have services that handle these scenarios, which are called at the appropriate times. So, before adding the two-part tariff supplementary flagging logic, we prepare the existing services for reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4201
In Move reusable supplementary billing services we shifted some existing supplementary billing services to make them reusable by the two-part tariff supplementary billing engine we're building.
Our spike has shown there are some two-part tariff annual billing services we can also make reusable.