New Widget: Slider #5208
Open
New Widget: Slider #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just like Range_Slider except that it has only one slider bar.
myk002
reviewed
Jan 20, 2025
myk002
reviewed
Feb 17, 2025
There was a problem hiding this comment.
this is cleaner, but not quite clean enough. The RangeSlider attributes are still visible in Slider, but are useless, which leads to a confusing API.
I think both RangeSlider and Slider should inherit from a base class that holds the common logic, keeping the externally visible ATTRS clean for both classes.
|
|
||
| This widget implements a mouse-interactable slider. The player can move the handle to | ||
| set the value of the slider. The parent widget owns the slider value, and can control | ||
| it independently (e.g., with ``CycleHotkeyLabels``). If the value changes, the ``Slider`` |
There was a problem hiding this comment.
Suggested change
| it independently (e.g., with ``CycleHotkeyLabels``). If the value changes, the ``Slider`` | |
| it independently (e.g., with a ``CycleHotkeyLabel``). If the value changes, the ``Slider`` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just like Range_Slider except that it has only one slider bar.