Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Implementation of findfilesbymetadata 's method into rucio file catalog client #8006

Conversation

gillardoLapp
Copy link

@gillardoLapp gillardoLapp commented Jan 23, 2025

BEGINRELEASENOTES

*Resources
NEW: Implementation of findfilesbymetadata 's method into rucio file catalog client

ENDRELEASENOTES

fstagni and others added 30 commits September 22, 2024 22:54
…d47dc1-integration

[sweep:integration] fix: added fromAddress for notification emails
…19913b-integration

[sweep:integration] fix: added a 30s gfal2 timeout for downloading the SRR
…be1513-integration

[sweep:integration] SSHCE, Try python3 before unversioned python
…9-integration

[sweep:integration] fix: new pylint version fixes
…integration

[sweep:integration] Change the updating logic of the TS FileStatus
…integration

[sweep:integration] Support token transfers in FTS
…ad3240-integration

[sweep:integration] fix(resources): AREXCE should return an error if queue is not found
[integration] Getting pilot reference from job parameters
…Path

fix(WMS): SandboxStore not able to assign a sandbox to a job
…are-command

fix(WMS): JobWrapper checks existence of executable in jobIDPath
fstagni and others added 21 commits January 28, 2025 12:55
…fd2f8c-integration

[sweep:integration] fix: Adapt AREXCE arc7 delegation new response
[9.0] fix: typo dirax -> diracx
…d-integration

[sweep:integration] StalledJobAgent: if StartExecTime is not set, use the last recorded heartbeat
…0-integration

[sweep:integration] fix:  make 2 methods of WorkflowTaskAgent extendable
…a-integration

[sweep:integration] Fix return code
…5207d2-integration

[sweep:integration] explicitly disconnect Stomp before reconnecting
…dc03c2-integration

[sweep:integration] fix (Core): limit read to TLS payload size
…7-integration

[sweep:integration] fix: make the setting of inputDataBulk extendable
…ce1a7a-integration

[sweep:integration] fix: restored empty line
…e-integration

[sweep:integration] Use apptainer for SingularityComputingElement and enhance debugging
@gillardoLapp
Copy link
Author

Hi, do I need to make any changes for this PR to be accepted?

@fstagni fstagni requested a review from cserf February 5, 2025 13:05
@fstagni
Copy link
Contributor

fstagni commented Feb 5, 2025

Hi, do I need to make any changes for this PR to be accepted?

Hi, yes! As you can see there are a few failing checks. Since they might not be obvious (they aren't!):

  1. For the pre-commit check: https://github.com/DIRACGrid/DIRAC?tab=readme-ov-file#code-quality is hopefully enough
  2. For the Commit Message Check: you should reword your commits so that they follow the pattern in https://github.com/DIRACGrid/DIRAC/blob/integration/.github/workflows/semantic.yml#L18 (so, something like "fix: this is meaningful explanation for a fix"
  3. For the docs check, fix these:
/home/docs/checkouts/readthedocs.org/user_builds/dirac/checkouts/8006/docs/source/DeveloperGuide/CodeTesting/index.rst:364: WARNING: Footnote [#] is not referenced. [ref.footnote]
/home/docs/checkouts/readthedocs.org/user_builds/dirac/checkouts/8006/docs/source/DeveloperGuide/CodeTesting/index.rst:365: WARNING: Footnote [#] is not referenced. [ref.footnote]
/home/docs/checkouts/readthedocs.org/user_builds/dirac/checkouts/8006/docs/source/DeveloperGuide/CodeTesting/index.rst:366: WARNING: Footnote [#] is not referenced. [ref.footnote]

And finally, the PR should be reviewed. I have just assigned @cserf as reviewer.

@gillardoLapp gillardoLapp force-pushed the Implementation-of-FindFilesByMetadatamethod-into-RucioFileCatalogClient branch 2 times, most recently from 61be825 to 3efa4ef Compare February 12, 2025 10:41
@fstagni
Copy link
Contributor

fstagni commented Feb 13, 2025

Replaced by #8046 I guess...

@fstagni fstagni closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants