Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update node image #90

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

aldbr
Copy link
Contributor

@aldbr aldbr commented Mar 28, 2024

#77 is stuck and I need to update the node image to keep working with a mounted diracx-web version as NextJS14 does not support node v16 anymore (deprecated by the way).

Update: I found a minor issue where the diracx-web pod does not start if node_modules or .next directories do not exist. I fixed that by:

  • adding a mkdir -p line in run_demo. It solves the issue and works correctly, now I am not sure whether it is elegant.
  • mounting the node package in read+write mode instead of read-only: this is because next-env.d.ts is generated/updated by npm run dev. As we are in development mode, it would not a problem, wouldn't it? + There is an attempt to move this file into the .next directory, let's see how it goes.

@aldbr aldbr force-pushed the main_FEAT_update-node-image branch from 4112046 to 171c54f Compare March 28, 2024 09:46
@aldbr aldbr requested review from chrisburr and chaen March 28, 2024 09:53
@aldbr aldbr force-pushed the main_FEAT_update-node-image branch 2 times, most recently from c5d6e5a to decacb0 Compare March 28, 2024 12:41
@aldbr aldbr force-pushed the main_FEAT_update-node-image branch from decacb0 to 0ce806a Compare March 28, 2024 13:10
@chrisburr chrisburr merged commit bc3baa0 into DIRACGrid:master Mar 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants