Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing impute2 with Beagle; Support for hg19 and hg38 reference genomes #20
base: master
Are you sure you want to change the base?
Replacing impute2 with Beagle; Support for hg19 and hg38 reference genomes #20
Changes from 47 commits
ea53bd3
3836328
bba909d
e0d4a50
9586a6a
3109026
5e86bfa
3b3d7fb
68f24bc
4ba122f
1dd2cf7
530ba17
78e1612
1888521
368a3c5
1a8069a
de2b5a0
a96db03
eff8785
e49047a
9600f4b
27451e6
c8a953f
0a6de5a
fd79e51
c9aa6a0
2160ea7
f880d0a
f11ed17
9a41797
1061eeb
13bdfe2
cfec6c9
944304d
72f796b
232cbd0
94b4eb4
081e236
524037d
14954cd
a2e30c1
df9e662
778079b
118f4c6
87f6439
209a232
5e7fdbc
e8a7fc7
5004ae1
a8b2f55
19b3100
5c4ad09
3d16416
346e68a
b139c9a
9b86c36
52c6c5a
7b0d1ff
f52f086
e6a5845
30555e1
09bd58f
fe1b82b
d5706f9
232a81d
e3fc99f
1229a24
eb26938
e783d7e
6549fe0
779d5b0
fc26eb6
8655540
8a29539
8ffd230
2d0ec65
8eda5e9
ab85dc9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script uses a specific version of Java (1.8.0_131). If the script is intended to be used in different environments, consider checking for the Java version dynamically or allowing the user to specify the Java version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
reference_genome
variable is used before it is set. You should definereference_path
before this line.Commitable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line assumes that the reference genome file is formatted in a specific way. If the format changes, this line may not work as expected. Consider adding a comment to explain the expected format of the reference genome file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script removes the
ref
andout
directories at the end. If these directories existed before the script was run, their contents will be lost. Consider creating unique temporary directories instead.And replace all
ref
andout
with${ref_dir}
and${out_dir}
respectively. At the end, replacerm -r ref out
withrm -r ${ref_dir} ${out_dir}
.Commitable suggestion