Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(#53) swagger setting #55

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Feat(#53) swagger setting #55

merged 2 commits into from
Jan 21, 2024

Conversation

rndudals
Copy link
Contributor

@rndudals rndudals commented Jan 21, 2024

#️⃣ 연관된 이슈

ex) #이슈번호

Pull Request Type

어떤 변경 사항이 있나요?

  • 새로운 기능 추가
  • 코드 리팩토링
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 테스트 추가, 테스트 리팩토링
  • 코드에 영향을 주지 않는 변경사항
    • 오타 수정, 문서 수정, 변수명 변경, 주석 추가 및 수정

Pull Request Checklist

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • 변경 사항에 대한 테스트를 모두 통과했나요?
  • 코드 정렬은 적용했나요?
  • 새로운 branch에 작업 후 dev로 PR을 요청했나요?

📝 작업 내용

Swagger Setting

  • ProjectConfig : prod, !prod로 구분, dev 환경에서는 모든 url 허용
  • SecurityConfig : swagger url추가
  • Swagger Info, Servers, SecurityScheme 설정
스크린샷 2024-01-21 113921

💬 리뷰 요구사항

피드백 감사하겠습니다ㅎㅎ

* ProjectConfig : prod, !prod로 구분, dev 환경에서는 모든 url 허용
* SecurityConfig : swagger url추가
* Swagger Info, Servers, SecurityScheme 설정
@rndudals rndudals added the chore label Jan 21, 2024
@rndudals rndudals self-assigned this Jan 21, 2024
Copy link

📝 테스트 커버리지 리포트

Overall Project 85.19% -0.2% 🍏
Files changed 95.05% 🍏

File Coverage
SwaggerConfig.java 100% 🍏
SecurityConfig.java 100% 🍏
ProjectConfig.java 91.53% -8.47% 🍏

Copy link
Contributor

@ghdcksgml1 ghdcksgml1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 API 들 잘 동작하는지 확인해주세용!! /auth/loginPage같은 부분들

@rndudals
Copy link
Contributor Author

동작 안하나요?? 확인해보겠습니다!!

@rndudals rndudals merged commit 5225b10 into dev Jan 21, 2024
3 checks passed
Copy link
Contributor

@jusung-c jusung-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨슴미다!!

@rndudals rndudals deleted the feat(#53)-Swagger-setting branch January 21, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants