-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] feat(#39): 유저 정보 조회 #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* @AuthenticationPrincipal 어노테이션 사용 -> (인증된 사용자의 정보) * user info DTO 추가 * 예외 메시지 추가
* userInfoTest 구현
* name, profileImageUrl -> platformId, platformType 변경
jusung-c
reviewed
Jan 31, 2024
backend/src/main/java/com/example/backend/auth/api/controller/auth/AuthController.java
Outdated
Show resolved
Hide resolved
* 사용자 정보 조회 userservice 구현
* 세션 사용자 정보 -> db 사용자 정보 조회 변경 * 예외메시지 추가 * Test 수정 (Json path 변경)
📝 테스트 커버리지 리포트
|
|
* UserService 제거 -> AuthService에 반영 * 컨트롤러 리팩토링 -> AuthService
authService를 @Autowired로 주입하면 이유를 모르겠습니다. |
@MockBean 테스트는 가짜 객체를 넣어주는 테스트여서 실제 작동을 하지 않는 걸로 알고 있어욥. authService 동작에 대한 테스트는 AuthServiceTest에서 진행하시면 될 것 같아요! |
* when( ) 메서드로 동작 지정 * getUserByInfo 테스트
jusung-c
requested changes
Feb 1, 2024
backend/src/main/java/com/example/backend/common/exception/ExceptionMessage.java
Show resolved
Hide resolved
backend/src/main/java/com/example/backend/auth/api/service/auth/AuthService.java
Outdated
Show resolved
Hide resolved
* UserException 추가 * 조회 정보 없으면 null -> 예외
jusung-c
approved these changes
Feb 1, 2024
ghdcksgml1
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#39
Pull Request Type
어떤 변경 사항이 있나요?
Pull Request Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
📝 작업 내용
💬 리뷰 요구사항
유저정보 조회 성공 테스트가 안되고있는데 일단 res_code가 200이 나오고 res_obj에서 몇개만 불러와지는 상황입니다.