-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.3 erase certificate feature for SET_CERTIFICATE
#2433
Conversation
c7a9f75
to
118fd69
Compare
ad26d56
to
0a8f7b7
Compare
90c20ad
to
a0913e6
Compare
SET_CERTIFICATE
a0913e6
to
966d747
Compare
966d747
to
c3742be
Compare
e337b5d
to
6d9aa22
Compare
@steven-bellock Hi Steven, could you review again? I have fixed the code based on your feedback. |
@Wenxing-hou the comment in https://github.com/DMTF/libspdm/pull/2433/files#r1400951233 is still valid. If the message was sent in a session then libspdm can check the exact size, else it cannot. |
6d9aa22
to
d56fc8a
Compare
Thanks. I have fixed the code based on the feedback. |
d56fc8a
to
91c980c
Compare
91c980c
to
02bed09
Compare
And I have added the table in code comment: libspdm/include/internal/libspdm_responder_lib.h Lines 678 to 690 in 02bed09
|
Fix the issue: DMTF#2292 Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
02bed09
to
08b571b
Compare
Ref: #2292
The code has passed the unit_test.