Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List major changes #2335

Merged
merged 2 commits into from
Feb 20, 2025
Merged

List major changes #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f38e9f8
List major changes
jwillemsen Feb 19, 2025
7269189
Fixed typo
jwillemsen Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ACE/NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
USER VISIBLE CHANGES BETWEEN ACE-8.0.2 and ACE-8.0.3
====================================================

. Deprecated ACE_Copy_Disabled in favor of deleted copy/assignment

. Replaced usage of ACE_MIN and ACE_MAX with std::min/std::max

. Add support for abstract paths to ACE_UNIX_ADDR

. Improve support for 64bit file sizes

Comment on lines +10 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify the extent of 64-bit file size improvements.

The changelog entry about improved 64-bit file size support is vague. It would be helpful to verify which specific file operations now support 64-bit sizes.

🏁 Script executed:

#!/bin/bash
# Search for file size related changes
rg -A 5 "ACE_(UINT|INT)64.*file" 
rg -A 5 "fseek|ftell|lseek|off_t"

Length of output: 58783

Action Required: Clarify Specific 64-Bit File Operation Enhancements

The NEWS entry remains quite terse. Based on our investigation, several file operations (such as lseek/llseek wrappers, ftell, and related offset management routines using types like ACE_OFF_T) have been updated for 64‑bit support. However, the changelog and accompanying documentation do not clearly enumerate which functions are affected.

  • Please specify in the NEWS entry which file operations have been enhanced (for example, ACE_OS::lseek, ACE_OS::ftell, and any custom wrappers) so that users and maintainers know the full scope of 64‑bit file size support.
  • Update the changelog to detail these modifications where applicable.

. Minor fixes to ACE logging classes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify the nature of logging fixes.

The entry "Minor fixes to ACE logging classes" lacks specificity. Let's check what logging issues were addressed.

🏁 Script executed:

#!/bin/bash
# Search for logging-related changes
rg -A 5 "ACE_Log|logging"

Length of output: 124154

Clarify logging fixes in the commit message
The NEWS entry "Minor fixes to ACE logging classes" is too generic. The logging-related search output spans many historical changes, and it isn’t clear which specific issues this commit addresses. Please update the commit message or extend the NEWS entry to briefly summarize which logging concerns were fixed (for example, improvements in error handling, formatting adjustments, or thread-safety enhancements). This added detail will help maintainers understand the scope and impact of these changes.


. Use C++11 default for more classes

USER VISIBLE CHANGES BETWEEN ACE-8.0.1 and ACE-8.0.2
====================================================

Expand Down
8 changes: 8 additions & 0 deletions TAO/NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
USER VISIBLE CHANGES BETWEEN TAO-4.0.2 and TAO-4.0.3
====================================================

. Add new CECShutdownWaitCompletion command line argument to CosEvent service
in order to be able not to wait on any pending event on shutdown

. Fixed possible race condition when handling location forwards

. When no preferred interfaces are provided we don't query for all IP interfaces
as that could be slow

USER VISIBLE CHANGES BETWEEN TAO-4.0.1 and TAO-4.0.2
====================================================

Expand Down
Loading