Allow to mark multiple balloons as done #3303
Open
+204
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
reviewed
Dec 16, 2025
| } | ||
|
|
||
| uasort($teamSummary, function ($a, $b) { | ||
| $aKey = $a['location'] ?? $a['team']->getExternalId(); |
Member
There was a problem hiding this comment.
For us location can be a string right? So those can be the same, maybe also append the externalId to it to make sure you can always sort?
vmcj
reviewed
Dec 16, 2025
| ->setParameter('balloonIds', $balloonId) | ||
| ->getQuery() | ||
| ->getResult(); | ||
| if (empty($balloons)) { |
Member
There was a problem hiding this comment.
Suggested change
| if (empty($balloons)) { | |
| if (count($balloons) !== count((array)$balloonId)) { |
Member
There was a problem hiding this comment.
So we drop the message if any of the balloonIds is invalid (for whatever reason)...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 2 features to the balloon page:
Both were requested by Marius during SEERC 2025 and I think both make sense.