fix(gatsby): invalidate cache in more conditions, e.g. require statements #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the cache invalidation algorithm. Rather than merely relying on the content of the files, it now will attempt to parse require statements in gatsby-config.js or gatsby-node.js, and add those required files as hashes used to invalidate. Particularly, this will help solve cache invalidation on something like reactjs/reactjs.org, where pieces of gatsby-node.js are in disparate require'd files, which will not currently invalidate the cache upon changing
…-cache-gatsby-node-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a very WIP PR that will use babel-traverse to parse the AST of various files (e.g. gatsby-config.js, gatsby-node.js, etc.) and invalidate the cache when require'd files change, rather than just if the files themselves change.
For instance, given the following
gatsby-node.js:Prior to this functionality, if we were to make a change to
./gatsby/create-pages, gatsby is none the wiser and will not invalidate the cache.I did this pretty briefly, so I know it's not ready for prime time, but if someone wants to take this and run with it--would be great!
Known Issues
Related Issues
gatsbyjs/gatsby@11952