Add deprecation warning #467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavidBM thanks for this notice. It helped me to distinguish pros and cons in this question: https://stackoverflow.com/questions/70701405/what-sha256-rust-implementation-take-for-no-std-embedded-device |
|
The @rustsec project has filed The advisory suggests several alternatives. |
brainstorm
added a commit
to umccr/crypt4gh-rust
that referenced
this pull request
Jun 19, 2023
…ute rust-crypto: https://rustsec.org/advisories/RUSTSEC-2016-0005.html Also coming from unmerged PR DaGenix/rust-crypto#467 This crate change is required to be Crypt4GH spec-compliant (see section 5.1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
So this crate in wonderful and helped a lot some time ago.
Said that, newest commit in this project dates from 5 years ago. Sometimes, when searching things like "scrypt rust" in search engines you get this repository as first result, which is dangerous as it wasn't maintained for 5 year now. See also: https://rustsec.org/advisories/RUSTSEC-2016-0005.html
I think at least this project can show a deprecation warning in the Readme in order to point to https://github.com/RustCrypto/ which is properly maintained.
Hope this PR comes well.
And thanks for all the Job done on this crate.