Projectilesimprovement #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo: https://streamable.com/wnj3mf Features: - Full support for most gradients/vectors/numbers/generators/transforms ( I might have forgotten some of the more esoteric ones) - A "tutorial" section that explains the different rand/generation types and how physics works with pictures - Button for viewing what each var does - Selecting a particle type to set immediately - The generator types use defines now Not included: Color matrix support for color generators (I'm sorry but hell no) Special thanks to @jlsnow301 for explaining js things to me Making cool stuf :cl: refactor: Added a particle editor to VV dropdown which can be used by coders and admins to edit particle values on the fly easily. /:cl: Co-authored-by: TiviPlus <[email protected]>
It isn't really an issue now, but these will be used more in future, so let's start off strong. There's a lot of work going on here that doesn't really need to be happening, mostly off not knowing a trickTM. Biggest one is vis_locs and vis_contents are linked lists, being in one requires being in another. Atoms clear out their vis_locs on Destroy, so we do not need to "own" references to things that have us in their vis_contents. This combined with knowing our old loc's loc off Moved made the use of weakrefs here unneeded. Similarly, atoms inside atom movables qdel on when the upper layer is deleted, so most cases of the qdeleting signal were unneeded. Also, we only cared about movement if we were an item (speaking of which, I swapped out the isitem stuff with a flag that gets passed into the new() call) Speed
Mobs on fire and wet mobs get cool particle effects https://user-images.githubusercontent.com/82850673/230459326-184b5553-17db-49df-997f-8db4c87df601.mp4 fire particles (big fire) small fire just reduces the spawn rate of particles to 20% of this https://user-images.githubusercontent.com/82850673/230468680-b831e557-bb0a-4489-8aef-4fefdfc14e43.mp4 wet particles sick :cl: add: Mobs on fire get particle effects (it looks sick) add: Wet mobs get particle effects (it looks sick) /:cl:
Particle holders are placed into the contents of the thing they're showing the particles off of. This creates problems as some items can drop all their contents to the ground or, in the case of storage items, use their contents in some way Fixes particle holders falling out of items. :cl: fix: Fixed particles sometimes being left behind when an object drops all of its contents whilst having a particle active. /:cl: --------- Co-authored-by: Watermelon914 <[email protected]>
## About The Pull Request The harddel hunt continues...  This stupid mythril coin has come up a bunch of times in our CI recently and it is starting to annoy me. This should fix it hopefully. Attempts to get rid of a potential source of harddels in particle_holder.dm ## Why It's Good For The Game ## Changelog :cl: fix: fixes a harddel in particle holders /:cl:
|
this one seems familiar |
This was referenced Jan 28, 2024
DaedalusDock-Services
pushed a commit
that referenced
this pull request
Jan 31, 2024
This was referenced Feb 4, 2024
QuacksQ
added a commit
to Artea-Station/Artea-Station-Server
that referenced
this pull request
Oct 5, 2024
## About The Pull Request This pr yoinks the bullet sprite from Mojave Sun and the idea to make them light up from DD, credit goes to the original Pr and codebase respectively: - DaedalusDock/daedalusdock#782 - https://github.com/Mojave-Sun/mojave-sun-13/blob/master/mojave/icons/objects/projectiles/projectiles.dmi The sprite:  ## How Does This Help ***Gameplay***? Cooler visuals to look at are nice while gaming :) ## How Does This Help ***Roleplay***? Minimal impact on RP ## Proof of Testing <details> <summary>Screenshots/Videos</summary> <!-- Leave the line after this one empty. Embeds like breaking if you don't --> ## OLD https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/139032f4-0cf7-4c16-885e-0ba030120c55 ## NEW https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/cd060115-e57e-4c1a-9594-ff0ef68e2315 </details> ## Changelog :cl: imageadd: Bullets now have a new sprite! /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Changelog
🆑 TiviPlus, LemonInTheDark, ChungusGamer666, Watermelon914, vinylspiders, tyeagg, Kapu1178
add: Added new particle effects for being on fire or wet.
add: Added new particle effects for firing ballistic weapons.
add: Added new particle effects for bullets impacting surfaces.
add: Bullets are now illuminated.
add: Bullets leave behind impact holes on most surfaces.
/:cl: