Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves investigate_log #854

Merged
merged 5 commits into from
Apr 13, 2024
Merged

improves investigate_log #854

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
297b550
improves investigate_log
Kapu1178 Feb 29, 2024
ca48576
Update code/game/machinery/computer/security.dm
Kapu1178 Feb 29, 2024
fa558ba
Update code/game/machinery/computer/security.dm
Kapu1178 Feb 29, 2024
2492292
Update code/game/machinery/computer/security.dm
Kapu1178 Feb 29, 2024
b3f486d
Update code/game/machinery/computer/security.dm
Kapu1178 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 63 additions & 4 deletions code/game/machinery/computer/security.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,7 @@ What a mess.*/
return
if(!(R.fields["criminal"] == CRIMINAL_WANTED))
return
investigate_log("[key_name(usr)] send a security status broadcast for [R.fields["name"]].", INVESTIGATE_RECORDS)

SEND_GLOBAL_SIGNAL(COMSIG_GLOB_WANTED_CRIMINAL, R)

Expand Down Expand Up @@ -670,7 +671,9 @@ Age: [active1.fields["age"]]<BR>"}
var/counter = 1
while(active2.fields["com_[counter]"])
counter++
active2.fields["com_[counter]"] = "Made by [src.authenticated] ([src.rank]) on [stationtime2text()] [time2text(world.realtime, "MMM DD")], [CURRENT_STATION_YEAR]<BR>[t1]"
active2.fields["com_[counter]"] = "Made by [src.authenticated] ([src.rank]) on [stationtime2text()] [stationdate2text()], [CURRENT_STATION_YEAR]<BR>[t1]"

investigate_log("[key_name(usr)] created a new comment for [active2.fields["name"]]: [html_encode(t1)].")

if("Delete Record (ALL)")
if(active1)
Expand All @@ -687,6 +690,7 @@ Age: [active1.fields["age"]]<BR>"}
if("Delete Entry")
if((istype(active2, /datum/data/record) && active2.fields["com_[href_list["del_c"]]"]))
active2.fields["com_[href_list["del_c"]]"] = "<B>Deleted</B>"
investigate_log("[key_name(usr)] deleted a record entry: [active2.fields["name"]].", INVESTIGATE_RECORDS)
//RECORD CREATE
if("New Record (Security)")
if((istype(active1, /datum/data/record) && !( istype(active2, /datum/data/record) )))
Expand All @@ -700,6 +704,7 @@ Age: [active1.fields["age"]]<BR>"}
GLOB.data_core.security += R
active2 = R
screen = 3
investigate_log("[key_name(usr)] created a new security record.")

if("New Record (General)")
//General Record
Expand Down Expand Up @@ -748,6 +753,8 @@ Age: [active1.fields["age"]]<BR>"}
M.fields["notes"] = "No notes."
GLOB.data_core.medical += M

investigate_log("[key_name(usr)] created a new record of each type.")



//FIELD FUNCTIONS
Expand All @@ -762,54 +769,71 @@ Age: [active1.fields["age"]]<BR>"}
if(!canUseSecurityRecordsConsole(usr, t1, a1))
return
if(istype(active1, /datum/data/record))
investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s record: Var: name | Old value:[active1.fields["name"]] | New value: [t1].", INVESTIGATE_RECORDS)
active1.fields["name"] = t1
if(istype(active2, /datum/data/record))
investigate_log("[key_name(usr)] updated [active2.fields["name"]]'s record: Var: name | Old value:[active2.fields["name"]] | New value: [t1].", INVESTIGATE_RECORDS)
active2.fields["name"] = t1
if("id")
if(istype(active2, /datum/data/record) || istype(active1, /datum/data/record))
var/t1 = tgui_input_text(usr, "Input an id", "Security Records", active1.fields["id"])
if(!canUseSecurityRecordsConsole(usr, t1, a1))
return
if(istype(active1, /datum/data/record))
investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s record: Var: id | Old value:[active1.fields["id"]] | New value: [t1].", INVESTIGATE_RECORDS)
active1.fields["id"] = t1
if(istype(active2, /datum/data/record))
investigate_log("[key_name(usr)] updated [active2.fields["name"]]'s record: Var: id | Old value:[active2.fields["id"]] | New value: [t1].", INVESTIGATE_RECORDS)
active2.fields["id"] = t1

if("fingerprint")
if(istype(active1, /datum/data/record))
var/t1 = tgui_input_text(usr, "Input a fingerprint hash", "Security Records", active1.fields["fingerprint"])
if(!canUseSecurityRecordsConsole(usr, t1, a1))
return
investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s record: Var: fingerprint | Old value:[active1.fields["fingerprint"]] | New value: [t1].", INVESTIGATE_RECORDS)
active1.fields["fingerprint"] = t1

if("gender")
if(istype(active1, /datum/data/record))
var/new_gender
if(active1.fields["gender"] == "Male")
active1.fields["gender"] = "Female"
new_gender = "Female"
else if(active1.fields["gender"] == "Female")
active1.fields["gender"] = "Other"
new_gender = "Other"
else
active1.fields["gender"] = "Male"
new_gender = "Male"

investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s record: Var: gender | Old value:[active1.fields["gender"]] | New value: [new_gender].", INVESTIGATE_RECORDS)
active1.fields["gender"] = new_gender

if("age")
if(istype(active1, /datum/data/record))
var/t1 = tgui_input_number(usr, "Input age", "Security records", active1.fields["age"], AGE_MAX, AGE_MIN)
if (!t1)
return
if(!canUseSecurityRecordsConsole(usr, "age", a1))
return
investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s record: Var: age | Old value:[active1.fields["age"]] | New value: [t1].", INVESTIGATE_RECORDS)
active1.fields["age"] = t1

if("species")
if(istype(active1, /datum/data/record))
var/t1 = tgui_input_list(usr, "Select a species", "Species Selection", get_selectable_species())
if(isnull(t1))
return
if(!canUseSecurityRecordsConsole(usr, t1, a1))
return
investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s record: Var: species | Old value:[active1.fields["species"]] | New value: [t1].", INVESTIGATE_RECORDS)
active1.fields["species"] = t1

if("show_photo_front")
if(active1)
var/front_photo = active1.get_front_photo()
if(istype(front_photo, /obj/item/photo))
var/obj/item/photo/photo = front_photo
photo.show(usr)

if("upd_photo_front")
var/obj/item/photo/photo = get_photo(usr)
if(photo)
Expand All @@ -822,18 +846,22 @@ Age: [active1.fields["age"]]<BR>"}
var/dh = w - 32
I.Crop(dw/2, dh/2, w - dw/2, h - dh/2)
active1.fields["photo_front"] = photo
investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s front photo.", INVESTIGATE_RECORDS)

if("print_photo_front")
if(active1)
var/front_photo = active1.get_front_photo()
if(istype(front_photo, /obj/item/photo))
var/obj/item/photo/photo_front = front_photo
print_photo(photo_front.picture.picture_image, active1.fields["name"])

if("show_photo_side")
if(active1)
var/side_photo = active1.get_side_photo()
if(istype(side_photo, /obj/item/photo))
var/obj/item/photo/photo = side_photo
photo.show(usr)

if("upd_photo_side")
var/obj/item/photo/photo = get_photo(usr)
if(photo)
Expand All @@ -846,12 +874,15 @@ Age: [active1.fields["age"]]<BR>"}
var/dh = w - 32
I.Crop(dw/2, dh/2, w - dw/2, h - dh/2)
active1.fields["photo_side"] = photo
investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s front photo.", INVESTIGATE_RECORDS)

if("print_photo_side")
if(active1)
var/side_photo = active1.get_side_photo()
if(istype(side_photo, /obj/item/photo))
var/obj/item/photo/photo_side = side_photo
print_photo(photo_side.picture.picture_image, active1.fields["name"])

if("crim_add")
if(istype(active1, /datum/data/record))
var/t1 = tgui_input_text(usr, "Input crime names", "Security Records")
Expand All @@ -861,12 +892,24 @@ Age: [active1.fields["age"]]<BR>"}
var/crime = GLOB.data_core.createCrimeEntry(t1, t2, authenticated, stationtime2text())
GLOB.data_core.addCrime(active1.fields["id"], crime)
investigate_log("New Crime: <strong>[t1]</strong>: [t2] | Added to [active1.fields["name"]] by [key_name(usr)]", INVESTIGATE_RECORDS)

if("crim_delete")
if(istype(active1, /datum/data/record))
if(href_list["cdataid"])
if(!canUseSecurityRecordsConsole(usr, "delete", null, a2))
return
var/crime_name = ""
var/crime_details = ""
var/list/crimes = active1.fields["citation"]
for(var/datum/data/crime/crime in crimes)
if(crime.dataId == text2num(href_list["cdataid"]))
crime_name = crime.crimeName
crime_details = crime.crimeDetails
break

investigate_log("[key_name(usr)] deleted a crime from [active1.fields["name"]]: ([crime_name]) | Details: [crime_details]", INVESTIGATE_RECORDS)
GLOB.data_core.removeCrime(active1.fields["id"],href_list["cdataid"])

if("add_details")
if(istype(active1, /datum/data/record))
if(href_list["cdataid"])
Expand All @@ -875,6 +918,7 @@ Age: [active1.fields["age"]]<BR>"}
return
GLOB.data_core.addCrimeDetails(active1.fields["id"], href_list["cdataid"], t1)
investigate_log("New Crime details: [t1] | Added to [active1.fields["name"]] by [key_name(usr)]", INVESTIGATE_RECORDS)

if("citation_add")
if(istype(active1, /datum/data/record))
var/maxFine = CONFIG_GET(number/maxfine)
Expand All @@ -892,18 +936,31 @@ Age: [active1.fields["age"]]<BR>"}
GLOB.data_core.addCitation(active1.fields["id"], crime)
investigate_log("New Citation: <strong>[t1]</strong> Fine: [fine] | Added to [active1.fields["name"]] by [key_name(usr)]", INVESTIGATE_RECORDS)
SSblackbox.ReportCitation(crime.dataId, usr.ckey, usr.real_name, active1.fields["name"], t1, fine)

if("citation_delete")
if(istype(active1, /datum/data/record))
if(href_list["cdataid"])
if(!canUseSecurityRecordsConsole(usr, "delete", null, a2))
return
var/crime_name = ""
var/crime_details = ""
var/list/crimes = active1.fields["citation"]
for(var/datum/data/crime/crime in crimes)
if(crime.dataId == text2num(href_list["cdataid"]))
crime_name = crime.crimeName
crime_details = crime.crimeDetails
break

investigate_log("[key_name(usr)] deleted a citation from [active1.fields["name"]]: ([crime_name]) | Details: [crime_details]", INVESTIGATE_RECORDS)
GLOB.data_core.removeCitation(active1.fields["id"], href_list["cdataid"])
if("notes")
if(istype(active2, /datum/data/record))
var/t1 = tgui_input_text(usr, "Please summarize notes", "Security Records", active2.fields["notes"])
if(!canUseSecurityRecordsConsole(usr, t1, null, a2))
return
investigate_log("[key_name(usr)] updated [active2.fields["name"]]'s notes to: [t1]", INVESTIGATE_RECORDS)
active2.fields["notes"] = t1

if("criminal")
if(istype(active2, /datum/data/record))
temp = "<h5>Criminal Status:</h5>"
Expand Down Expand Up @@ -944,8 +1001,10 @@ Age: [active1.fields["age"]]<BR>"}
if(ispath(path))
var/rank = SSid_access.station_job_templates[path]
if(rank)
investigate_log("[key_name(usr)] updated [active1.fields["name"]]'s record: Var: rank | Old value:[active1.fields["rank"]] | New value: [rank].", INVESTIGATE_RECORDS)
active1.fields["rank"] = rank
active1.fields["trim"] = active1.fields["rank"]

else
message_admins("Warning: possible href exploit by [key_name(usr)] - attempted to set change a crew member rank to an invalid path: [path]")
log_game("Warning: possible href exploit by [key_name(usr)] - attempted to set change a crew member rank to an invalid path: [path]")
Expand Down
10 changes: 8 additions & 2 deletions code/modules/admin/admin_investigate.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
/atom/proc/investigate_log(message, subject)
if(!message || !subject)
return
var/F = file("[GLOB.log_directory]/[subject].html")
WRITE_FILE(F, "[time_stamp()] [REF(src)] ([x],[y],[z]) || [src] [message]<br>")

var/source = "[src]"

if(isliving(src))
var/mob/living/source_mob = src
source += " ([source_mob.ckey ? source_mob.ckey : "*no key*"])"

rustg_file_append("[time_stamp("YYYY-MM-DD hh:mm:ss")] [REF(src)] ([x],[y],[z]) || [source] [message]<br>", "[GLOB.log_directory]/[subject].html")

/client/proc/investigate_show()
set name = "Investigate"
Expand Down
Loading